Updating more documentation.

Author: biscuitWizard

vcs-worker/src/operations/index/index_update_op.rs

@@ -7,6 +7,7 @@ use crate::database::{DatabaseRef, ObjectsTreeError};
 use crate::types::User;
 use crate::providers::index::IndexProvider;
 use crate::object_diff::{ObjectDiffModel, build_object_diff_from_change};
+use moor_var::{v_error, E_INVARG};
 
 /// Request structure for index update operations
 #[derive(Debug, Clone, Serialize, Deserialize)]
@@ -54,7 +55,7 @@ impl IndexUpdateOperation {
             }
             None => {
                 error!("No source URL found in index - nothing to update");
-                return Ok(moor_var::v_str("Error: No source URL configured. This repository was not cloned from a remote source."));
+                return Err(ObjectsTreeError::SerializationError("No source URL configured. This repository was not cloned from a remote source.".to_string()));
             }
         };
 
@@ -318,23 +319,37 @@ impl Operation for IndexUpdateOperation {
         use crate::operations::OperationResponse;
         vec![
             OperationResponse::success(
-                "Operation executed successfully",
-                r#""Operation completed successfully""#
+                "Operation executed successfully - Index is up to date",
+                r#""Index is up to date""#
+            ),
+            OperationResponse::success(
+                "Operation executed successfully - Full clone completed",
+                r#""Cloned successfully from http://example.com:8081 - 5 changes, 42 objects""#
+            ),
+            OperationResponse::new(
+                400,
+                "Bad Request - No source URL configured",
+                r#"E_INVARG("No source URL configured. This repository was not cloned from a remote source.")"#
             ),
             OperationResponse::new(
                 400,
-                "Bad Request - Invalid arguments",
-                r#""Error: Invalid operation arguments""#
+                "Bad Request - Failed to parse delta from remote",
+                r#"E_INVARG("Failed to parse delta: invalid JSON")"#
             ),
             OperationResponse::new(
-                404,
-                "Not Found - Resource not found",
-                r#""Error: Resource not found""#
+                500,
+                "Internal Server Error - HTTP request to remote failed",
+                r#"E_INVARG("HTTP request failed: connection refused")"#
+            ),
+            OperationResponse::new(
+                500,
+                "Internal Server Error - Channel closed during update",
+                r#"E_INVARG("Channel closed during update")"#
             ),
             OperationResponse::new(
                 500,
                 "Internal Server Error - Database or system error",
-                r#""Error: Database error: operation failed""#
+                r#"E_INVARG("Database error: failed to get change order")"#
             ),
         ]
     }
@@ -351,7 +366,7 @@ impl Operation for IndexUpdateOperation {
             }
             Err(e) => {
                 error!("Index update operation failed: {}", e);
-                moor_var::v_str(&format!("Error: {e}"))
+                v_error(E_INVARG.msg(format!("{e}")))
             }
         }
     }

vcs-worker/src/operations/system/status_op.rs

@@ -6,6 +6,7 @@ use crate::database::{DatabaseRef, ObjectsTreeError};
 use crate::types::{User, ChangeStatus};
 use crate::providers::index::IndexProvider;
 use crate::providers::workspace::WorkspaceProvider;
+use moor_var::{v_error, E_INVARG};
 
 /// System status operation that provides comprehensive repository status information
 #[derive(Clone)]
@@ -195,22 +196,12 @@ impl Operation for StatusOperation {
         vec![
             OperationResponse::success(
                 "Operation executed successfully",
-                r#""Operation completed successfully""#
-            ),
-            OperationResponse::new(
-                400,
-                "Bad Request - Invalid arguments",
-                r#""Error: Invalid operation arguments""#
-            ),
-            OperationResponse::new(
-                404,
-                "Not Found - Resource not found",
-                r#""Error: Resource not found""#
+                r#"["game_name" -> "MyGame", "top_change_id" -> "abc123def456...", "top_change_short_id" -> "abc123", "idle_changes" -> 2, "pending_review" -> 1, "current_username" -> "player", "changes_in_index" -> 5, "latest_merged_change" -> ["id" -> "def789ghi012...", "short_id" -> "def789", "author" -> "player", "timestamp" -> 1697040000, "message" -> "Fixed login bug"], "index_partition_size" -> 1048576, "refs_partition_size" -> 4096, "objects_partition_size" -> 8388608, "remote_url" -> "http://example.com/repo", "pending_updates" -> 0]"#
             ),
             OperationResponse::new(
                 500,
-                "Internal Server Error - Database or system error",
-                r#""Error: Database error: operation failed""#
+                "Internal Server Error - Database error",
+                r#"E_INVARG("Database error: failed to get change order")"#
             ),
         ]
     }
@@ -225,7 +216,7 @@ impl Operation for StatusOperation {
             }
             Err(e) => {
                 error!("System status operation failed: {}", e);
-                moor_var::v_str(&format!("Error: {e}"))
+                v_error(E_INVARG.msg(format!("{e}")))
             }
         }
     }