Skip to content

Commit 3da4fae

Browse files
committed
fix more tests
1 parent 4b66957 commit 3da4fae

File tree

2 files changed

+17
-8
lines changed

2 files changed

+17
-8
lines changed

services/api-server/src/simcore_service_api_server/api/routes/functions_routes.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -446,7 +446,7 @@ async def map_function(
446446
function_job_collection=FunctionJobCollection(
447447
title="Function job collection of function map",
448448
description=function_job_collection_description,
449-
job_ids=jobs, # type: ignore
449+
job_ids=[job.uid for job in jobs], # type: ignore
450450
),
451451
user_id=user_identity.user_id,
452452
product_name=user_identity.product_name,

services/api-server/tests/unit/api_functions/celery/test_functions_celery.py

Lines changed: 16 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -419,10 +419,14 @@ def _default_side_effect(
419419
"get_function", return_value=fake_registered_project_function
420420
)
421421
mock_handler_in_functions_rpc_interface(
422-
"find_cached_function_jobs", return_value=[]
422+
"find_cached_function_jobs", side_effect=_find_cached_function_jobs_side_effect
423423
)
424424
mock_handler_in_functions_rpc_interface(
425-
"register_function_job", return_value=fake_registered_project_function_job
425+
"register_function_job",
426+
side_effect=partial(
427+
_register_function_job_side_effect,
428+
fake_registered_project_function_job,
429+
),
426430
)
427431
mock_handler_in_functions_rpc_interface(
428432
"get_functions_user_api_access_rights",
@@ -539,10 +543,14 @@ def _default_side_effect(
539543
"get_function", return_value=fake_registered_project_function
540544
)
541545
mock_handler_in_functions_rpc_interface(
542-
"find_cached_function_jobs", return_value=[]
546+
"find_cached_function_jobs", side_effect=_find_cached_function_jobs_side_effect
543547
)
544548
mock_handler_in_functions_rpc_interface(
545-
"register_function_job", return_value=fake_registered_project_function_job
549+
"register_function_job",
550+
side_effect=partial(
551+
_register_function_job_side_effect,
552+
fake_registered_project_function_job,
553+
),
546554
)
547555
mock_handler_in_functions_rpc_interface(
548556
"get_functions_user_api_access_rights",
@@ -593,9 +601,10 @@ def _default_side_effect(
593601

594602
if expected_status_code == status.HTTP_200_OK:
595603
FunctionJobCollection.model_validate(response.json())
596-
task_id = patch_mock.call_args.kwargs[
597-
"registered_function_job_patch"
598-
].job_creation_task_id
604+
task_id = patch_mock.call_args.kwargs["registered_function_job_patch_inputs"][
605+
0
606+
].patch.job_creation_task_id
607+
assert task_id is not None
599608
await _wait_for_task_result(client, auth, f"{task_id}")
600609
assert side_effect_checks["headers_checked"] is True
601610

0 commit comments

Comments
 (0)