CatHash images are not persisted

[HenrikJannsen]

The CatHash image classes support persisting the images so that they are not re-created each time as the creating is expensive.
Also the local caching is supported in the base classes and should be reused instead the custom implementation for caching.

Lot of images add memory pressure when kept in ram. We need some policy to keep the in-memory items limited.

[rodvar]

Are you referring to the node app or the connect apps? I'll answer both here cause this might be a misconception:

• Android Node side: I understand this would be handled by the bisq2 persistence + caching ? AndroidNodeCatHashService delegates persistence/caching to bisq.user.cathash.CatHashService and only implements platform-specific compose/read/write. Images are saved to disk and reloaded instead of being re-composed each time.
• Connect side (for reference): We have an explicit, bounded in-memory cache and on-disk cache in BaseClientCatHashService with a clear policy to limit RAM usage.

please confirm, moving to discussion

[HenrikJannsen]

I refer to node and there are no images persisted. Look up the data dir, in cache there should be a sub dir for it.
I can look into it...

[HenrikJannsen]

Close as it is fixed with #701