Skip to content

Improve handling of new version enforcement #4205

@HenrikJannsen

Description

@HenrikJannsen

When we enforce a new version for trading, the user can still create and if the taker has the new version he can take the offer, but then it fails at the next trade message.
We also show the generic error popup instead of a more user friendly message.

We should:

  • Don't allow to create an offer if version it too low
  • Fail at the earliest trade message
  • Use a user friendly popup instead of generic error popup

We have already a error popup for expected error cases as shown below. This should be used for the case the error is triggered in the protocol (not at create offer).

Image

Using that code:

 new Popup().headline(Res.get("bisqEasy.openTrades.atPeer.failure.popup.headline"))
                                        .failure(Res.get("bisqEasy.openTrades.failure.popup.message.header"),
                                                peersErrorMessage,
                                                Res.get("bisqEasy.openTrades.failure.popup.message.footer"))
                                        .show();

Metadata

Metadata

Assignees

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions