Skip to content

Commit 7e45843

Browse files
authored
Add tests for existing functionality (#9)
* Make demo_frame.js smarter * Verify HTML and JS content in tests * zombie uses jsdom which does not support dataset
1 parent eff1cb5 commit 7e45843

File tree

8 files changed

+352
-112
lines changed

8 files changed

+352
-112
lines changed

.gitignore

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
11
node_modules/
2-
temp/
2+
test/temp/

demo_frame.js

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -45,9 +45,11 @@ module.exports = function(node){
4545
var dataForHtml = node.querySelector("[data-for=html] > pre");
4646
dataForHtml.innerHTML = prettyify(html);
4747

48-
var dataForJS = node.querySelector("[data-for=js] > pre");
49-
dataForJS.innerHTML = prettyify(js.replace(/\t/g," "));
50-
show(node.querySelector("[data-tab=js]"));
48+
if (js) {
49+
var dataForJS = node.querySelector("[data-for=js] > pre");
50+
dataForJS.innerHTML = prettyify(js.replace(/\t/g," "));
51+
show(node.querySelector("[data-tab=js]"));
52+
}
5153

5254
tabs();
5355
}
@@ -86,11 +88,11 @@ module.exports = function(node){
8688
}
8789
}
8890
}
89-
return source.trim();
91+
return (source ? source.trim() : '');
9092
}
9193

9294
function show(el) {
93-
el.style.display = "block";
95+
el.style.display = "";
9496
}
9597

9698
function hide(el) {
@@ -101,7 +103,7 @@ module.exports = function(node){
101103
node.querySelector("ul").addEventListener("click", function(ev){
102104
var el = ev.target;
103105
if(el.className === "tab") {
104-
toggle(el.dataset.tab);
106+
toggle(el.dataset ? el.dataset.tab : el.getAttribute("data-tab"));
105107
}
106108
});
107109
toggle("demo");

package.json

Lines changed: 29 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -2,37 +2,42 @@
22
"name": "bit-docs-tag-demo",
33
"version": "0.3.0",
44
"description": "@demo tag for bit-docs",
5-
"main": "demo.js",
6-
"scripts": {
7-
"test": "mocha test.js --reporter spec",
8-
"postversion": "git push --tags && git push",
9-
"preversion": "npm test",
10-
"release:pre": "npm version prerelease && npm publish",
11-
"release:patch": "npm version patch && npm publish",
12-
"release:minor": "npm version minor && npm publish",
13-
"release:major": "npm version major && npm publish"
14-
},
15-
"repository": {
16-
"type": "git",
17-
"url": "git+ssh://[email protected]/bit-docs/bit-docs-tag-demo.git"
18-
},
195
"keywords": [
206
"bit-docs"
217
],
22-
"author": "Bitovi",
23-
"license": "MIT",
8+
"homepage": "https://github.com/bit-docs/bit-docs-tag-demo#readme",
249
"bugs": {
2510
"url": "https://github.com/bit-docs/bit-docs-tag-demo/issues"
2611
},
27-
"homepage": "https://github.com/bit-docs/bit-docs-tag-demo#readme",
28-
"dependencies": {
29-
"bit-docs-process-tags": "^0.0.3",
30-
"bit-docs-type-annotate": "^0.0.1"
12+
"license": "MIT",
13+
"author": "Bitovi",
14+
"main": "demo.js",
15+
"repository": {
16+
"type": "git",
17+
"url": "git+ssh://[email protected]/bit-docs/bit-docs-tag-demo.git"
18+
},
19+
"scripts": {
20+
"release:major": "npm version major && npm publish",
21+
"release:minor": "npm version minor && npm publish",
22+
"release:patch": "npm version patch && npm publish",
23+
"release:pre": "npm version prerelease && npm publish",
24+
"test": "mocha test.js --reporter spec",
25+
"preversion": "npm test",
26+
"postversion": "git push --tags && git push"
3127
},
3228
"devDependencies": {
33-
"bit-docs-generate-html": "^0.2.0",
34-
"connect": "^2.14.4",
35-
"mocha": "^2.5.3",
36-
"zombie": "^4.2.1"
29+
"bit-docs-generate-html": "0.5.0-pre.4",
30+
"can-stache": "3.0.20",
31+
"express": "^4.15.2",
32+
"mocha": "^3.2.0",
33+
"rimraf": "^2.6.1",
34+
"steal": "^1.4.6",
35+
"steal-less": "^1.2.0",
36+
"zombie": "^5.0.5"
37+
},
38+
"steal": {
39+
"plugins": [
40+
"steal-less"
41+
]
3742
}
3843
}

0 commit comments

Comments
 (0)