Merge pull request #56 from bitExpert/fix/migrate_phpunit_11

Migrate to PHPUnit 11 attributes

Author: shochdoerfer

phpunit.xml.dist

@@ -3,6 +3,11 @@
 <phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
          xsi:noNamespaceSchemaLocation="http://schema.phpunit.de/8.5/phpunit.xsd"
          colors="true"
+         displayDetailsOnTestsThatTriggerDeprecations="true"
+         displayDetailsOnPhpunitDeprecations="true"
+         displayDetailsOnTestsThatTriggerWarnings="true"
+         displayDetailsOnTestsThatTriggerErrors="true"
+         failOnPhpunitDeprecation="false"
          bootstrap="tests/Unit/bootstrap.php">
     <testsuites>
         <testsuite name="default">

tests/Unit/Events/ForceLoginRequestEventTest.php

@@ -14,6 +14,8 @@
 
 use BitExpert\SyliusForceCustomerLoginPlugin\Events\ForceLoginRequestEvent;
 use BitExpert\SyliusForceCustomerLoginPlugin\Http\DefaultRouteChecker;
+use PHPUnit\Framework\Attributes\DataProvider;
+use PHPUnit\Framework\Attributes\Test;
 use Symfony\Bundle\SecurityBundle\Security;
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpKernel\Event\RequestEvent;
@@ -51,9 +53,7 @@ protected function setUp(): void
         );
     }
 
-    /**
-     * @test
-     */
+    #[Test]
     public function requestEventIsIgnoredForSubRequest(): void
     {
         $this->eventMock->method('isMainRequest')->willReturn(false);
@@ -63,9 +63,7 @@ public function requestEventIsIgnoredForSubRequest(): void
         $this->forceLoginRequestEvent->onKernelRequest($this->eventMock);
     }
 
-    /**
-     * @test
-     */
+    #[Test]
     public function requestEventIsIgnoredForLoggedInUser(): void
     {
         $user = $this->createMock(UserInterface::class);
@@ -79,9 +77,8 @@ public function requestEventIsIgnoredForLoggedInUser(): void
         $this->forceLoginRequestEvent->onKernelRequest($this->eventMock);
     }
 
-    /**
-     * @dataProvider whitelistedUrls
-     */
+    #[Test]
+    #[DataProvider('whitelistedUrls')]
     public function whitelistedUrlsAlwaysGrantAccess(string $url): void
     {
         $request = Request::create($url);
@@ -95,9 +92,8 @@ public function whitelistedUrlsAlwaysGrantAccess(string $url): void
         $this->assertTrue(true);
     }
 
-    /**
-     * @dataProvider whitelistedUrlsWithLocale
-     */
+    #[Test]
+    #[DataProvider('whitelistedUrlsWithLocale')]
     public function whitelistedUrlsWithLocaleAlwaysGrantAccess(string $url): void
     {
         $request = Request::create($url);
@@ -111,9 +107,7 @@ public function whitelistedUrlsWithLocaleAlwaysGrantAccess(string $url): void
         $this->assertTrue(true);
     }
 
-    /**
-     * @test
-     */
+    #[Test]
     public function urlWithNoAccessGrantedThrowsAccessDeniedException(): void
     {
         $this->expectException(AccessDeniedException::class);
@@ -129,9 +123,7 @@ public function urlWithNoAccessGrantedThrowsAccessDeniedException(): void
         $this->forceLoginRequestEvent->onKernelRequest($this->eventMock);
     }
 
-    /**
-     * @test
-     */
+    #[Test]
     public function accessGrantedSucceeds(): void
     {
         $url = '/taxons/caps/with-pompons';
@@ -146,11 +138,11 @@ public function accessGrantedSucceeds(): void
         $this->assertTrue(true);
     }
 
-    public function whitelistedUrls(): array
+    public static function whitelistedUrls(): array
     {
         return [
             ['/_wdt'],
-            ['/profiler'],
+            ['/_profiler'],
             ['/admin'],
             ['/login'],
             ['/register'],
@@ -160,7 +152,7 @@ public function whitelistedUrls(): array
         ];
     }
 
-    public function whitelistedUrlsWithLocale(): array
+    public static function whitelistedUrlsWithLocale(): array
     {
         return [
             ['/en'],

tests/Unit/Model/RegexMatcherTest.php

@@ -14,23 +14,20 @@
 
 use BitExpert\SyliusForceCustomerLoginPlugin\Model\RegexMatcher;
 use BitExpert\SyliusForceCustomerLoginPlugin\Model\WhitelistEntry;
+use PHPUnit\Framework\Attributes\Test;
 use PHPUnit\Framework\TestCase;
 
 class RegexMatcherTest extends TestCase
 {
-    /**
-     * @test
-     */
+    #[Test]
     public function checkMatcherType(): void
     {
         $matcher = new RegexMatcher();
 
         $this->assertEquals('regex', $matcher->getType());
     }
 
-    /**
-     * @test
-     */
+    #[Test]
     public function routeIsRegexMatch(): void
     {
         $whitelistEntry = new WhitelistEntry();
@@ -43,9 +40,7 @@ public function routeIsRegexMatch(): void
         $this->assertTrue($matcher->isMatch($pathInfo, $whitelistEntry));
     }
 
-    /**
-     * @test
-     */
+    #[Test]
     public function routeIsNoRegexMatch(): void
     {
         $whitelistEntry = new WhitelistEntry();

tests/Unit/Model/StaticMatcherTest.php

@@ -14,23 +14,20 @@
 
 use BitExpert\SyliusForceCustomerLoginPlugin\Model\StaticMatcher;
 use BitExpert\SyliusForceCustomerLoginPlugin\Model\WhitelistEntry;
+use PHPUnit\Framework\Attributes\Test;
 use PHPUnit\Framework\TestCase;
 
 class StaticMatcherTest extends TestCase
 {
-    /**
-     * @test
-     */
+    #[Test]
     public function checkMatcherType(): void
     {
         $matcher = new StaticMatcher();
 
         $this->assertEquals('static', $matcher->getType());
     }
 
-    /**
-     * @test
-     */
+    #[Test]
     public function routeIsStaticMatch(): void
     {
         $whitelistEntry = new WhitelistEntry();
@@ -43,9 +40,7 @@ public function routeIsStaticMatch(): void
         $this->assertTrue($matcher->isMatch($pathInfo, $whitelistEntry));
     }
 
-    /**
-     * @test
-     */
+    #[Test]
     public function routeIsNoStaticMatch(): void
     {
         $whitelistEntry = new WhitelistEntry();

tests/Unit/Model/WhitelistEntryTest.php

@@ -13,14 +13,13 @@
 namespace Model;
 
 use BitExpert\SyliusForceCustomerLoginPlugin\Model\WhitelistEntry;
+use PHPUnit\Framework\Attributes\Test;
 use PHPUnit\Framework\TestCase;
 use Sylius\Component\Core\Model\Channel;
 
 class WhitelistEntryTest extends TestCase
 {
-    /**
-     * @test
-     */
+    #[Test]
     public function addChannelToWhitelist(): void
     {
         $channel = new class() extends Channel {
@@ -38,9 +37,7 @@ public function getId()
         $this->assertTrue($whitelistEntry->hasChannel($channel));
     }
 
-    /**
-     * @test
-     */
+    #[Test]
     public function addSameChannelToWhitelistOnlyOnce(): void
     {
         $channel = new class() extends Channel {
@@ -58,9 +55,7 @@ public function getId()
         $this->assertCount(1, $whitelistEntry->getChannels());
     }
 
-    /**
-     * @test
-     */
+    #[Test]
     public function removeChannelFromWhitelist(): void
     {
         $channel = new class() extends Channel {
@@ -78,9 +73,7 @@ public function getId()
         $this->assertCount(0, $whitelistEntry->getChannels());
     }
 
-    /**
-     * @test
-     */
+    #[Test]
     public function removeChannelFromWhitelistMultipleTimesCausesNoError(): void
     {
         $channel = new class() extends Channel {

tests/Unit/Voter/RequestWhitelistVoterTest.php

@@ -16,6 +16,7 @@
 use BitExpert\SyliusForceCustomerLoginPlugin\Model\StaticMatcher;
 use BitExpert\SyliusForceCustomerLoginPlugin\Model\WhitelistEntry;
 use BitExpert\SyliusForceCustomerLoginPlugin\Voter\RequestWhitelistVoter;
+use PHPUnit\Framework\Attributes\Test;
 use PHPUnit\Framework\TestCase;
 use Sylius\Component\Channel\Context\ChannelContextInterface;
 use Sylius\Component\Core\Model\ChannelInterface;
@@ -42,9 +43,7 @@ protected function setUp(): void
         );
     }
 
-    /**
-     * @test
-     */
+    #[Test]
     public function voteAbstainForNonRequestSubjects()
     {
         $token = $this->createMock(TokenInterface::class);
@@ -55,9 +54,7 @@ public function voteAbstainForNonRequestSubjects()
         $this->assertEquals(VoterInterface::ACCESS_ABSTAIN, $result);
     }
 
-    /**
-     * @test
-     */
+    #[Test]
     public function voteGrantedWhenRequestUriMatchesWhitelistEntry()
     {
         $url = '/taxons/caps/simple/';
@@ -77,9 +74,7 @@ public function voteGrantedWhenRequestUriMatchesWhitelistEntry()
         $this->assertEquals(VoterInterface::ACCESS_GRANTED, $result);
     }
 
-    /**
-     * @test
-     */
+    #[Test]
     public function voteDeniedWhenRequestUriDoesNotMatchWhitelistEntry()
     {
         $url = '/taxons/caps/simple/';
@@ -99,9 +94,7 @@ public function voteDeniedWhenRequestUriDoesNotMatchWhitelistEntry()
         $this->assertEquals(VoterInterface::ACCESS_DENIED, $result);
     }
 
-    /**
-     * @test
-     */
+    #[Test]
     public function voteAbstainedWhenSubjectTypeDoesNotMatchString()
     {
         $url = $this->createMock(Request::class);