Skip to content

Commit 96eab57

Browse files
committed
test: reenable LedgerX tests
1 parent 4e342db commit 96eab57

File tree

1 file changed

+0
-20
lines changed

1 file changed

+0
-20
lines changed

test/test_device.py

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -586,20 +586,12 @@ def test_signtx(self):
586586
# https://github.com/bitcoin-core/HWI/pull/795#issuecomment-3112271927
587587
raise unittest.SkipTest("Coldcard sign test temporarily disabled")
588588

589-
if self.emulator.type == "ledger" and not self.emulator.legacy:
590-
# https://github.com/bitcoin-core/HWI/pull/795#issuecomment-3112271927
591-
raise unittest.SkipTest("Test temporarily disabled for NanoX")
592-
593589
for addrtypes, multisig_types, external, op_return in self.signtx_cases:
594590
with self.subTest(addrtypes=addrtypes, multisig_types=multisig_types, external=external, op_return=op_return):
595591
self._test_signtx(addrtypes, multisig_types, external, op_return)
596592

597593
# Make a huge transaction which might cause some problems with different interfaces
598594
def test_big_tx(self):
599-
if self.emulator.type == "ledger" and not self.emulator.legacy:
600-
# https://github.com/bitcoin-core/HWI/pull/795#issuecomment-3112271927
601-
raise unittest.SkipTest("Test temporarily disabled for NanoX")
602-
603595
# make a huge transaction
604596
keypool_desc = self.do_command(self.dev_args + ["getkeypool", "--account", "10", "--addr-type", "sh_wit", "0", "100"])
605597
import_result = self.wrpc.importdescriptors(keypool_desc)
@@ -630,10 +622,6 @@ def test_big_tx(self):
630622

631623
class TestDisplayAddress(DeviceTestCase):
632624
def test_display_address_path(self):
633-
if self.emulator.type == "ledger" and not self.emulator.legacy:
634-
# https://github.com/bitcoin-core/HWI/pull/795#issuecomment-3112271927
635-
raise unittest.SkipTest("Test temporarily disabled for NanoX")
636-
637625
result = self.do_command(self.dev_args + ['displayaddress', "--addr-type", "legacy", '--path', 'm/44h/1h/0h/0/0'])
638626
if self.emulator.supports_legacy:
639627
self.assertNotIn('error', result)
@@ -659,10 +647,6 @@ def test_display_address_bad_path(self):
659647
self.assertEqual(result['code'], -7)
660648

661649
def test_display_address_descriptor(self):
662-
if self.emulator.type == "ledger" and not self.emulator.legacy:
663-
# https://github.com/bitcoin-core/HWI/pull/795#issuecomment-3112271927
664-
raise unittest.SkipTest("Test temporarily disabled for NanoX")
665-
666650
account_xpub = self.do_command(self.dev_args + ['getxpub', 'm/84h/1h/0h'])['xpub']
667651
p2sh_segwit_account_xpub = self.do_command(self.dev_args + ['getxpub', 'm/49h/1h/0h'])['xpub']
668652
legacy_account_xpub = self.do_command(self.dev_args + ['getxpub', 'm/44h/1h/0h'])['xpub']
@@ -784,10 +768,6 @@ def _check_sign_msg(self, msg):
784768
self.assertTrue(self.rpc.verifymessage(addr, sig, msg))
785769

786770
def test_sign_msg(self):
787-
if self.emulator.type == "ledger" and not self.emulator.legacy:
788-
# https://github.com/bitcoin-core/HWI/pull/795#issuecomment-3112271927
789-
raise unittest.SkipTest("Test temporarily disabled for NanoX")
790-
791771
self._check_sign_msg("Message signing test")
792772
self._check_sign_msg("285") # Specific test case for Ledger shorter S
793773

0 commit comments

Comments
 (0)