Merge #127: Handle GitHub bots that have invalid characters in their username

ece77f7 Handle GitHub bots that have invalid characters in their username (Alekos Filini)

Pull request description:

  I tried merging a PR that had a codecov comment with the new code coverage, and `github-merge.py` failed with:

  ```
  Warning: unable to retrieve pull information from github: Github username contains invalid characters: codecov[bot]
  Traceback (most recent call last):
    File "/home/user/Developer/bitcoin-maintainer-tools//github-merge.py", line 480, in <module>
      main()
    File "/home/user/Developer/bitcoin-maintainer-tools//github-merge.py", line 429, in main
      comments = retrieve_pr_comments(repo_from,pull,ghtoken) + retrieve_pr_reviews(repo_from,pull,ghtoken)
  TypeError: unsupported operand type(s) for +: 'NoneType' and 'list'
  ```

  I thought it would have been more conservative to just explicitly remove the `[bot]` suffix rather than adding square brackets to the regex.

Top commit has no ACKs.

Tree-SHA512: a617cec72ef9427f798e8c88f7c0873b46a2145e9f11620428de098241aefc7818a873efb5345dc659c6652bc55ee1b5dc6a72edb5fe72ac973d1a2ae60dda2b

Author: laanwj

github-merge.py

@@ -89,8 +89,9 @@ def sanitize_ghdata(rec):
         rec['user'] = {'login': '[deleted]'}
     else:
         # "Github username may only contain alphanumeric characters or hyphens'.
+        # Sometimes bot have a "[bot]" suffix in the login, so we also match for that
         # Use \Z instead of $ to not match final newline only end of string.
-        if not re.match('[a-zA-Z0-9-]+\Z', rec['user']['login'], re.DOTALL):
+        if not re.match('[a-zA-Z0-9-]+(\[bot\])?\Z', rec['user']['login'], re.DOTALL):
             raise ValueError('Github username contains invalid characters: {}'.format(sanitize(rec['user']['login'])))
     return rec