Merge #128: make-tag: Remove MSVC check

e4ba90f make-tag: Remove MSVC check (laanwj)

Pull request description:

  The MSVC check is no longer necessary as of bitcoin/bitcoin#23198, which generates the version information by parsing `configure.ac`.

  (we likely want to backport that to 22.1 as well, to avoid needing three variants of the make-tag script)

Top commit has no ACKs.

Tree-SHA512: 408e3cad8da718b9c57f68756183c7cfb38883b266402d13d25abc8da8b18e849d84b1dcf4ae45b4c5e2ae66fca4aa288a0e1c3f7439b75a8205adbaf8648263

Author: laanwj

make-tag.py

@@ -90,41 +90,6 @@ def check_configure_ac(spec):
         print(f"{filename}: Version from tag {version_name(spec)} doesn't match specified version {version_name(cfg_spec)}", file=sys.stderr)
         sys.exit(1)
 
-def check_msvc_config_h(spec):
-    info = {}
-    filename = 'build_msvc/bitcoin_config.h'
-    with open(filename) as f:
-        for line in f:
-            m = re.match("#define ([A-Z_]+) (.+)$", line)
-            if m:
-                info[m.group(1)] = m.group(2)
-    # check if IS_RELEASE is set
-    if info["CLIENT_VERSION_IS_RELEASE"] != "true":
-        print(f'{filename}: IS_RELEASE is not set to true', file=sys.stderr)
-        sys.exit(1)
-
-    package_name = info['PACKAGE_NAME'][1:-1]
-    if info['PACKAGE_STRING'] != f'"{package_name} {spec.major}.{spec.minor}.{spec.build}"':
-        print(f'PACKAGE_STRING is not set correctly for msvc')
-        sys.exit(1)
-
-    if info['PACKAGE_VERSION'] != f'"{spec.major}.{spec.minor}.{spec.build}"':
-        print(f'PACKAGE_VERSION is not set correctly for msvc')
-        sys.exit(1)
-
-    msvc_spec = VersionSpec(
-            int(info['CLIENT_VERSION_MAJOR']),
-            int(info['CLIENT_VERSION_MINOR']),
-            int(info['CLIENT_VERSION_BUILD']),
-            None, # RC is not specified here
-        )
-
-    if (msvc_spec.major != spec.major or
-        msvc_spec.minor != spec.minor or
-        msvc_spec.build != spec.build):
-        print(f"{filename}: Version from tag {version_name(spec)} doesn't match specified version {version_name(msvc_spec)}", file=sys.stderr)
-        sys.exit(1)
-
 def main():
     try:
         tag = sys.argv[1]
@@ -147,9 +112,6 @@ def main():
     # Check version components against configure.ac in git tree
     check_configure_ac(spec)
 
-    # Check version components against MSVC build config
-    check_msvc_config_h(spec)
-
     # Generate base message
     if not spec.build:
         version = f"{spec.major}.{spec.minor}"