Merge #579: Tests: fix ignored return value from htmlproofer

b51e808 Tests: fix ignored return value from htmlproofer (David A. Harding)

Pull request description:

  In 0e7d61a, I broke the HTML proofer test.  Sorry.  It still generated warning messages but it always returned true, even when something was broken.  Happily, we didn't manage to break anything.

  This fixes the test.  Unlike before, I've tested that this does actually cause make (and thus Travis) to fail on broken content.

Tree-SHA512: 543a3dddf97909c8f0aff98bb35f327b20aa22a5340c1b01f0d1ec997a5ec418c7613ec42a5216c40ce6fa18fce1baef5963e214f9a8a1ca014ed03a727af3b8

Author: harding

Makefile

@@ -12,7 +12,7 @@ test: test-fast test-slow
 
 test-slow:
 	## Check for malformed HTML and broken internal links
-	bundle exec htmlproof --check-html --disable-external --url-ignore '/^\/bin/.*/' ./_site | cat
+	bash -c "set -o pipefail ; bundle exec htmlproof --check-html --disable-external --url-ignore '/^\/bin/.*/' ./_site | cat"
 	## Check that links on the /en/download page point to the separately-stored binaries in /bin
 	contrib/qa/test-binary-availability.sh && echo "SUCCESS checking URLs for binaries"