RPC doc generating script: always connect to regtest

The recommended network for generating RPC docs is regtest, as stated in the
script's file header comments:
"// (2) install bitcoin core, set it up to use regtest"

To achieve this, the user previosly needed to manually put `regtest=1` into
`~/.bitcoin/bitcoin.conf` -- the script didn't specify a concrete network, so
without config file setting, mainnet was used. With the change in this commit,
we will always connect to regtest by passing the `-regtest` option to the
`bitcoin-cli` invokation.

Author: theStack

contrib/doc-gen/generate.go

@@ -20,6 +20,7 @@ import (
 )
 
 const BITCOIN_COMMAND = "bitcoin-cli"
+const BITCOIN_CHAINOPTION = "-regtest"
 
 type Command struct {
 	Name        string
@@ -158,9 +159,10 @@ func open(path string) io.Writer {
 }
 
 func run(args ...string) string {
+	args = append([]string{BITCOIN_CHAINOPTION}, args...)
 	out, err := exec.Command(BITCOIN_COMMAND, args...).CombinedOutput()
 	if err != nil {
-		log.Fatalf("Cannot run bitcoin-cli: %s, is bitcoind running?", err.Error())
+		log.Fatalf("Cannot run bitcoin-cli: %s, is bitcoind (regtest) running?", err.Error())
 	}
 
 	return string(out)