Skip to content

Commit bd144e6

Browse files
committed
Merge #640: Download page: remove link to laanwj's key; mention --refresh-keys
88b6bf7 Download page: remove link to laanwj's key; mention --refresh-keys (David A. Harding) Pull request description: Recently, @laanwj's release signing key expired. He has uploaded to key servers an updated key with a future expiration date, but the copy of the key hosted on this server is still the expired version. Instead of updating it, this drops the link to it on the Download page and also adds a tiny note about `gpg --refresh-keys` Preview (bottom text): ![2019-02-15-15_40_34_052057138](https://user-images.githubusercontent.com/61096/52883516-3db9e280-3139-11e9-90bc-9ef3d9b1d5d5.png) The verification instructions on the page all mention getting the key with `--recv-keys` and there are no other links to the key on this site, so I think this is an acceptable solution. However, this PR leaves the actual expired key on the site in case any third party scripts are grabbing it automatically and just ignoring its expired status. ACKs for commit 88b6bf: Tree-SHA512: 873af52b6598fcbe78e4e2810ac9cfa86d47da83420cb5ac044e44f7f08f93ad7e38961d3e0df7e9017c55bfde0a4fda05d79617a40bfe0e781a41ed8522d728
2 parents 8ec2c07 + 88b6bf7 commit bd144e6

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

_includes/templates/download.html

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,8 @@ <h2>{{ page.latestversion }} {{CURRENT_RELEASE}} <a type="application/rss+xml" h
7474
</p>
7575
<p class="downloadkeys">
7676
<span>{{ page.releasekeys }}</span>
77-
<a href="/keys/laanwj-releases.asc">v0.11.0+</a> <code title="{{page.pgp_key_fingerprint}}">{{SIGNING_KEY_FINGERPRINT}}</code>
77+
v0.11.0+ <code title="{{page.pgp_key_fingerprint}}">{{SIGNING_KEY_FINGERPRINT}}</code><br>
78+
{% if page.version > 2 %}<i>{{page.key_refresh}}</i> <code>gpg --refresh-keys</code>{% endif %}
7879
</p>
7980
</div>
8081

_posts/en/pages/2017-01-01-download.md

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ type: pages
55
layout: page
66
lang: en
77
share: false
8-
version: 2
8+
version: 3
99

1010
## These strings need to be localized. In the listing below, the
1111
## comment above each entry contains the English text. The key before the
@@ -129,6 +129,7 @@ verifying_and_reproducing: >
129129
130130
gitian_repository: "trusted build process signatures"
131131

132+
key_refresh: "Refresh expired keys using:"
132133

133134
---
134135

0 commit comments

Comments
 (0)