Skip to content

Commit ca85967

Browse files
committed
Don't duplicate builder GPG key in bin verify
1 parent 41ec90e commit ca85967

File tree

2 files changed

+11
-6
lines changed

2 files changed

+11
-6
lines changed

_includes/templates/download.html

Lines changed: 11 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,14 @@
88
{% assign magnet = VERSION_SORTED_RELEASES[0].optional_magnetlink %}
99
{% capture PATH_PREFIX %}/bin/bitcoin-core-{{CURRENT_RELEASE}}{% endcapture %}
1010
{% capture FILE_PREFIX %}bitcoin-{{CURRENT_RELEASE}}{% endcapture %}
11-
{% capture SIGNING_KEY_FINGERPRINT_EXPLODED %}{% include fingerprint-split.html hex=page.example_builder_key %}{% endcapture %}
12-
{% capture SHORT_BUILDER_KEY %}{{page.example_builder_key | slice: 0, 4}} {{ page.example_builder_key | slice: 4, 4 }}...{% endcapture %}
11+
{% assign builder_line_arr = page.example_builders_line | split: ' ' %}
12+
{% assign example_builder_key = builder_line_arr[0] %}
13+
{% capture SIGNING_KEY_FINGERPRINT_EXPLODED %}
14+
{% include fingerprint-split.html hex=example_builder_key %}
15+
{% endcapture %}
16+
{% capture SHORT_BUILDER_KEY %}
17+
{{example_builder_key | slice: 0, 4}} {{ example_builder_key | slice: 4, 4 }}..
18+
.{% endcapture %}
1319
{% capture BUILDER_KEYS_TXT_URL %}{{page.builder_keys_url}}/keys.txt{% endcapture %}
1420

1521
{% capture OBTAIN_RELEASE_KEY %}
@@ -134,7 +140,7 @@ <h2 style="text-align: center" id="{{page.verify_download | slugify}}">{{page.ve
134140

135141
<li><p>{{OBTAIN_RELEASE_KEY}}</p>
136142

137-
<pre class="highlight"><code>{{GPG}}{{site.strings.gpg_keyserver}} --recv-keys {{page.example_builder_key}}</code></pre>
143+
<pre class="highlight"><code>{{GPG}}{{site.strings.gpg_keyserver}} --recv-keys {{example_builder_key}}</code></pre>
138144

139145
<p>{{page.release_key_obtained}}</p></li>
140146

@@ -182,7 +188,7 @@ <h2 style="text-align: center" id="{{page.verify_download | slugify}}">{{page.ve
182188

183189
<li><p>{{page.obtain_release_key | replace: '$(BUILDER_KEYS_URL)', page.builder_keys_url | replace: '$(EXAMPLE_BUILDERS_LINE)', page.example_builders_line}}</p>
184190

185-
<pre class="highlight"><code>gpg{{site.strings.gpg_keyserver}} --recv-keys {{page.example_builder_key}}</code></pre>
191+
<pre class="highlight"><code>gpg{{site.strings.gpg_keyserver}} --recv-keys {{example_builder_key}}</code></pre>
186192

187193
<p>{{page.release_key_obtained}}</p></li>
188194

@@ -224,7 +230,7 @@ <h2 style="text-align: center" id="{{page.verify_download | slugify}}">{{page.ve
224230

225231
<li><p>{{page.obtain_release_key | replace: '$(BUILDER_KEYS_URL)', page.builder_keys_url | replace: '$(EXAMPLE_BUILDERS_LINE)', page.example_builders_line}}</p>
226232

227-
<pre class="highlight"><code>gpg{{site.strings.gpg_keyserver}} --recv-keys {{page.example_builder_key}}</code></pre>
233+
<pre class="highlight"><code>gpg{{site.strings.gpg_keyserver}} --recv-keys {{example_builder_key}}</code></pre>
228234

229235
<p>{{page.release_key_obtained}}</p></li>
230236

_posts/en/pages/2017-01-01-download.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,6 @@ cd_example_windows: >
7979
verify_download_checksum: "Verify that the checksum of the release file is listed in the checksums file using the following command:"
8080
checksum_warning_and_ok: 'In the output produced by the above command, you can safely ignore any warnings and failures, but you must ensure the output lists "$(SHASUMS_OK)" after the name of the release file you downloaded. For example:'
8181

82-
example_builder_key: "E777299FC265DD04793070EB944D35F9AC3DB76A"
8382
example_builders_line: "E777299FC265DD04793070EB944D35F9AC3DB76A Michael Ford (fanquake)"
8483
builder_keys_url: "https://github.com/bitcoin/bitcoin/tree/master/contrib/builder-keys"
8584

0 commit comments

Comments
 (0)