Merge #359: Sync with the main repo

Pull request description:

  Sync with the main repo up to the latest bitcoin/bitcoin@ab42b2e, which includes the recent changes in the CI.

  There is no downloadable artifacts support for now. It will be done in a separated PR(s).

  Additionally:
  - The code was adjusted to reflect changes from [PR27419](bitcoin/bitcoin#27419), [PR27491](bitcoin/bitcoin#27491), [PR27576](bitcoin/bitcoin#27576) and [PR27636](bitcoin/bitcoin#27636).
  - Fixed `modernize-use-default-member-init` clang-tidy warnings.
  - The ARM task has been temporarily disabled until the issue with the depends cache is resolved.

  Guix builds:
  ```
  e92b8c4c3298165edb1a0e85ee516d52c81af1269405dcbc6520e63069de2363  guix-build-b3261144c892/output/aarch64-linux-gnu/SHA256SUMS.part
  939c6c002490d5649bdbfabacd20cd2270b41b20b7b3a254c9fcd5780209900d  guix-build-b3261144c892/output/aarch64-linux-gnu/bitcoin-b3261144c892-aarch64-linux-gnu-debug.tar.gz
  b3c1383fb394997378997bdd2933965cf4ecc694143b4703108ff6ecb946696c  guix-build-b3261144c892/output/aarch64-linux-gnu/bitcoin-b3261144c892-aarch64-linux-gnu.tar.gz
  f43fedf3af666d35e83b84e63cfe19f315f74f01296982f47d8c159385c3b03c  guix-build-b3261144c892/output/arm-linux-gnueabihf/SHA256SUMS.part
  73b89b0487e8eee474a6c9c96ae0e7ad635cccc332fc062eb5d4ff5555356c3e  guix-build-b3261144c892/output/arm-linux-gnueabihf/bitcoin-b3261144c892-arm-linux-gnueabihf-debug.tar.gz
  b4518dd9396f316de8d7de5181b8b5d1083e0afa9081625c37117472d2559380  guix-build-b3261144c892/output/arm-linux-gnueabihf/bitcoin-b3261144c892-arm-linux-gnueabihf.tar.gz
  0213e754408e2a032cef61a946354656f5b5f755f85aeac1ce4b37f1d22528e6  guix-build-b3261144c892/output/arm64-apple-darwin/SHA256SUMS.part
  11bc1be1f53dad337565f3c556dd69abc2d702a31e661359daad6ff89225c794  guix-build-b3261144c892/output/arm64-apple-darwin/bitcoin-b3261144c892-arm64-apple-darwin-unsigned.dmg
  558d8e805420c7a348759df6f559ca349953646aa28840efafe5a3d245ea917f  guix-build-b3261144c892/output/arm64-apple-darwin/bitcoin-b3261144c892-arm64-apple-darwin-unsigned.tar.gz
  e679ce3f1c80aff11a5eab8890efbd0d396a851875fbd6f93f32eef5cdf06813  guix-build-b3261144c892/output/arm64-apple-darwin/bitcoin-b3261144c892-arm64-apple-darwin.tar.gz
  0cb346390dc6620593b1af5b6669ddc3c1a8d2219a51b1697747c5ab24069c27  guix-build-b3261144c892/output/dist-archive/bitcoin-b3261144c892.tar.gz
  ac8bd2d58d9d0ebe2da1c8efa2d57bd97c3ef2b2590c758edbc4919808c528c5  guix-build-b3261144c892/output/powerpc64-linux-gnu/SHA256SUMS.part
  cdf8252fa8aca6da61ff6926de5c7e2e6560ab046049c84c26ba44823f83236a  guix-build-b3261144c892/output/powerpc64-linux-gnu/bitcoin-b3261144c892-powerpc64-linux-gnu-debug.tar.gz
  3b8b5f53d365b5bf962ecd7def9f06b6f13af0e5c9ef69c6d028f1ed772459be  guix-build-b3261144c892/output/powerpc64-linux-gnu/bitcoin-b3261144c892-powerpc64-linux-gnu.tar.gz
  b44e688d233dcb46a7d6d0b1d97979335d3cc559d16190cc5cd647add79298d2  guix-build-b3261144c892/output/powerpc64le-linux-gnu/SHA256SUMS.part
  ae5c19afefd523cdc171a3f9aa9f707870fd99749c01c01166086619dfd95ece  guix-build-b3261144c892/output/powerpc64le-linux-gnu/bitcoin-b3261144c892-powerpc64le-linux-gnu-debug.tar.gz
  bb581b1444fa1686f8889248af13d1859f2915091cd640bc522185d5ad83e13d  guix-build-b3261144c892/output/powerpc64le-linux-gnu/bitcoin-b3261144c892-powerpc64le-linux-gnu.tar.gz
  bdca0a3c19b5a9a5c72b2b43b07050678d960009d3fa80cf7e0689d508346974  guix-build-b3261144c892/output/riscv64-linux-gnu/SHA256SUMS.part
  b0b9c91abe2ad0b5ab3b0bfd10c90133d8d75b50aef0a6a98ac2c2ae4219eaa8  guix-build-b3261144c892/output/riscv64-linux-gnu/bitcoin-b3261144c892-riscv64-linux-gnu-debug.tar.gz
  fcce0ea00f1d9df136dd677cbc468183faa92bd4bfcd4a77cd1c70f1b894b5f0  guix-build-b3261144c892/output/riscv64-linux-gnu/bitcoin-b3261144c892-riscv64-linux-gnu.tar.gz
  7be84969950bb9570522be5a37551c01698cd3fb65eca3988fc9bd6867460552  guix-build-b3261144c892/output/x86_64-apple-darwin/SHA256SUMS.part
  25203f50aa6a344ad1c6c4a44a48082440bb0af9bf38f0d60506569f216d1672  guix-build-b3261144c892/output/x86_64-apple-darwin/bitcoin-b3261144c892-x86_64-apple-darwin-unsigned.dmg
  16c5baaf6d00ed43b0611c86c2d4555d500b3896daa1daac6a567bc2611c39f6  guix-build-b3261144c892/output/x86_64-apple-darwin/bitcoin-b3261144c892-x86_64-apple-darwin-unsigned.tar.gz
  86662f39c29b013b576e6555ecb6cbbc98eaa08532a541e22a7ed6b1baf87209  guix-build-b3261144c892/output/x86_64-apple-darwin/bitcoin-b3261144c892-x86_64-apple-darwin.tar.gz
  fbbc0ad2376431fdc5b214fd63f24a6da907d87f6f11e0833def50c0d45772cd  guix-build-b3261144c892/output/x86_64-linux-gnu/SHA256SUMS.part
  cba8d700f746a6063809570e45d6dc3d5e60ad5f1a28e0f41f8beed8b546a7b1  guix-build-b3261144c892/output/x86_64-linux-gnu/bitcoin-b3261144c892-x86_64-linux-gnu-debug.tar.gz
  0a32985a1e26e13ce883a85e4a92cc68bf51ce096f2f6d74ea499a9fa662d7d0  guix-build-b3261144c892/output/x86_64-linux-gnu/bitcoin-b3261144c892-x86_64-linux-gnu.tar.gz
  0bd4cc64cd6ad733cdef87cd74d5034e79dd250b72795cebf9c2c63500509457  guix-build-b3261144c892/output/x86_64-w64-mingw32/SHA256SUMS.part
  6ed8f2e6c6cf1992d156672707cd2c254754051f88223dd052a9cd9078d84789  guix-build-b3261144c892/output/x86_64-w64-mingw32/bitcoin-b3261144c892-win64-debug.zip
  1ea6d7660652e20b2b1529e406be1f606745d35f6a179b006335a19a19aa9a5b  guix-build-b3261144c892/output/x86_64-w64-mingw32/bitcoin-b3261144c892-win64-setup-unsigned.exe
  41b0f8cbac614e8c555921de60b25a73a75e6bed025de98ca40d3db48c5db6b1  guix-build-b3261144c892/output/x86_64-w64-mingw32/bitcoin-b3261144c892-win64-unsigned.tar.gz
  5c68d711782e76f9e4be93b5468c505f022b72ca299532b200e58fe1e51343b1  guix-build-b3261144c892/output/x86_64-w64-mingw32/bitcoin-b3261144c892-win64.zip
  ```

Top commit has no ACKs.

Tree-SHA512: dd18cfb2cfd6fd45b35bef8a0397bccc0752ce946b304bae986006ff09a9a183d6222b0f607e4dd3373992814ae0e61d5ba63cb54fef9a288152edef3d7ea81d

Author: hebasto

qml/README.md

@@ -4,18 +4,17 @@
 
 This directory contains the source code for an experimental Bitcoin Core graphical user interface (GUI) built using the [Qt Quick](https://doc.qt.io/qt-5/qtquick-index.html) framework.
 
-Unsecure CI artifacts are available for local testing of the master branch, avoiding the need to build:
-- for Windows: [`unsecure_win_gui.zip`](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/win64/unsecure_win_gui.zip)
-- for Intel macOS: [`unsecure_mac_gui.zip`](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos/unsecure_mac_gui.zip)
-- for Apple Silicon macOS: [`unsecure_mac_arm64_gui.zip`](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos_arm64/unsecure_mac_arm64_gui.zip)
-- for ARM64 Android: [`unsecure_android_apk.zip`](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/android/unsecure_android_apk.zip)
-- for ARM32 Android: [`unsecure_android_32bit_apk.zip`](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/android32/unsecure_android_32bit_apk.zip)
+Insecure CI artifacts are available for local testing of the master branch, avoiding the need to build:
+- for Windows: [`insecure_win_gui.zip`](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/win64/insecure_win_gui.zip)
+- for Intel macOS: [`insecure_mac_gui.zip`](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos/insecure_mac_gui.zip)
+- for Apple Silicon macOS: [`insecure_mac_arm64_gui.zip`](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/macos_arm64/insecure_mac_arm64_gui.zip)
+- for ARM64 Android: [`insecure_android_apk.zip`](https://api.cirrus-ci.com/v1/artifact/github/bitcoin-core/gui-qml/android/insecure_android_apk.zip)
 
 Note: For Apple Silicon macOS machines, the binary must be signed before it can
 be ran. To apply a signature, run the following on the unzipped CI artifact:
 
 ```
-codesign -s - ./Downloads/unsecure_mac_arm64_gui
+codesign -s - ./Downloads/insecure_mac_arm64_gui
 ```
 
 ## Goals and Limitations

qml/bitcoin.cpp

@@ -5,6 +5,8 @@
 #include <qml/bitcoin.h>
 
 #include <chainparams.h>
+#include <common/args.h>
+#include <common/system.h>
 #include <init.h>
 #include <interfaces/chain.h>
 #include <interfaces/init.h>
@@ -30,7 +32,6 @@
 #include <qt/initexecutor.h>
 #include <qt/networkstyle.h>
 #include <qt/peertablemodel.h>
-#include <util/system.h>
 #include <util/threadnames.h>
 #include <util/translation.h>
 
@@ -145,7 +146,7 @@ void setupChainQSettings(QGuiApplication* app, QString chain)
 int QmlGuiMain(int argc, char* argv[])
 {
 #ifdef WIN32
-    util::WinCmdLineArgs winArgs;
+    common::WinCmdLineArgs winArgs;
     std::tie(argc, argv) = winArgs.get();
 #endif // WIN32
 
@@ -192,7 +193,7 @@ int QmlGuiMain(int argc, char* argv[])
 
     /// Check for chain settings (Params() calls are only valid after this clause).
     try {
-        SelectParams(gArgs.GetChainName());
+        SelectParams(gArgs.GetChainType());
     } catch(std::exception &e) {
         InitError(Untranslated(strprintf("%s\n", e.what())));
         return EXIT_FAILURE;
@@ -248,7 +249,7 @@ int QmlGuiMain(int argc, char* argv[])
 #endif
 
     ChainModel chain_model{*chain};
-    chain_model.setCurrentNetworkName(QString::fromStdString(gArgs.GetChainName()));
+    chain_model.setCurrentNetworkName(QString::fromStdString(ChainTypeToString(gArgs.GetChainType())));
     setupChainQSettings(&app, chain_model.currentNetworkName());
 
     QObject::connect(&node_model, &NodeModel::setTimeRatioList, &chain_model, &ChainModel::setTimeRatioList);
@@ -268,7 +269,7 @@ int QmlGuiMain(int argc, char* argv[])
 
     QQmlApplicationEngine engine;
 
-    QScopedPointer<const NetworkStyle> network_style{NetworkStyle::instantiate(Params().NetworkIDString())};
+    QScopedPointer<const NetworkStyle> network_style{NetworkStyle::instantiate(Params().GetChainType())};
     assert(!network_style.isNull());
     engine.addImageProvider(QStringLiteral("images"), new ImageProvider{network_style.data()});
 

qml/components/blockclockdial.cpp

@@ -13,14 +13,7 @@
 #include <QtGlobal>
 
 BlockClockDial::BlockClockDial(QQuickItem *parent)
-: QQuickPaintedItem(parent)
-, m_time_ratio_list{0.0}
-, m_pen_width{4}
-, m_scale{5/12}
-, m_background_color{QColor("#2D2D2D")}
-, m_confirmation_colors{QList<QColor>{}}
-, m_time_tick_color{QColor("#000000")}
-, m_animation_timer{QTimer(this)}
+    : QQuickPaintedItem(parent)
 {
     m_animation_timer.setTimerType(Qt::PreciseTimer);
     m_animation_timer.setInterval(16);

qml/components/blockclockdial.h

@@ -68,20 +68,20 @@ public Q_SLOTS:
     qreal incrementAnimatingMaxAngle(qreal angle);
     qreal getTargetAnimationAngle();
 
-    QVariantList m_time_ratio_list;
+    QVariantList m_time_ratio_list{0.0};
     double m_verification_progress;
     bool m_is_connected;
     bool m_is_synced;
     bool m_is_paused;
-    qreal m_pen_width;
-    qreal m_scale;
-    QColor m_background_color;
+    qreal m_pen_width{4};
+    qreal m_scale{5/12};
+    QColor m_background_color{"#2D2D2D"};
     QConicalGradient m_connecting_gradient;
     qreal m_connecting_start_angle = 90;
     const qreal m_connecting_end_angle = -180;
-    QList<QColor> m_confirmation_colors;
-    QColor m_time_tick_color;
-    QTimer m_animation_timer;
+    QList<QColor> m_confirmation_colors{};
+    QColor m_time_tick_color{"#000000"};
+    QTimer m_animation_timer{this};
     QTimer m_delay_timer;
     qreal m_animating_max_angle = 0;
 };

qml/controls/linegraph.cpp

@@ -16,14 +16,6 @@
 
 LineGraph::LineGraph(QQuickItem *parent)
     : QQuickPaintedItem(parent)
-    , m_background_color{QColor("#2D2D2D")}
-    , m_border_color{QColor("#000000")}
-    , m_fill_color{QColor("#000000")}
-    , m_fill_gradient{QLinearGradient(0, 0, 0, 0)}
-    , m_line_color{QColor("#000000")}
-    , m_marker_line_color{("#000000")}
-    , m_max_samples{0}
-    , m_max_value{0}
 {
     setFillColor(m_background_color);
 }

qml/controls/linegraph.h

@@ -53,14 +53,14 @@ class LineGraph : public QQuickPaintedItem
         void paintTraffic(QPainter * painter);
         void setupGradient(QPainterPath * painter);
 
-        QColor m_background_color;
-        QColor m_border_color;
-        QColor m_fill_color;
-        QLinearGradient m_fill_gradient;
-        QColor m_line_color;
-        QColor m_marker_line_color;
-        int m_max_samples;
-        float m_max_value;
+        QColor m_background_color{"#2D2D2D"};
+        QColor m_border_color{"#000000"};
+        QColor m_fill_color{"#000000"};
+        QLinearGradient m_fill_gradient{0, 0, 0, 0};
+        QColor m_line_color{"#000000"};
+        QColor m_marker_line_color{"#000000"};
+        int m_max_samples{0};
+        float m_max_value{0};
         QQueue<float> m_value_list;
 };
 

qml/models/networktraffictower.cpp

@@ -12,10 +12,6 @@
 
 NetworkTrafficTower::NetworkTrafficTower(NodeModel& node)
     : m_node{node}
-    , m_total_bytes_received{0.0f}
-    , m_total_bytes_sent{0.0f}
-    , m_max_received_rate_bps{0.0f}
-    , m_max_sent_rate_bps{0.0f}
 {
     QTimer* timer = new QTimer();
     connect(timer, &QTimer::timeout, this, &NetworkTrafficTower::updateTrafficStats);

qml/models/networktraffictower.h

@@ -54,10 +54,10 @@ public Q_SLOTS:
 
     NodeModel& m_node;
     int m_filter_window_size;
-    float m_total_bytes_received;
-    float m_total_bytes_sent;
-    float m_max_received_rate_bps;
-    float m_max_sent_rate_bps;
+    float m_total_bytes_received{0.0f};
+    float m_total_bytes_sent{0.0f};
+    float m_max_received_rate_bps{0.0f};
+    float m_max_sent_rate_bps{0.0f};
     QQueue<float> m_received_rate_list;
     QQueue<float> m_smoothed_received_rate_list;
     QQueue<float> m_sent_rate_list;

qml/models/options_model.cpp

@@ -4,13 +4,14 @@
 
 #include <qml/models/options_model.h>
 
+#include <common/args.h>
+#include <common/settings.h>
+#include <common/system.h>
 #include <interfaces/node.h>
 #include <qt/guiconstants.h>
 #include <qt/optionsmodel.h>
 #include <txdb.h>
 #include <univalue.h>
-#include <util/settings.h>
-#include <util/system.h>
 #include <validation.h>
 
 #include <cassert>
@@ -99,7 +100,7 @@ void OptionsQmlModel::setUpnp(bool new_upnp)
     }
 }
 
-util::SettingsValue OptionsQmlModel::pruneSetting() const
+common::SettingsValue OptionsQmlModel::pruneSetting() const
 {
     assert(!m_prune || m_prune_size_gb >= 1);
     return m_prune ? PruneGBtoMiB(m_prune_size_gb) : 0;

qml/models/options_model.h

@@ -6,8 +6,8 @@
 #define BITCOIN_QML_MODELS_OPTIONS_MODEL_H
 
 #include <txdb.h>
-#include <util/settings.h>
-#include <util/system.h>
+#include <common/settings.h>
+#include <common/system.h>
 #include <validation.h>
 
 #include <QObject>
@@ -84,7 +84,7 @@ class OptionsQmlModel : public QObject
     bool m_server;
     bool m_upnp;
 
-    util::SettingsValue pruneSetting() const;
+    common::SettingsValue pruneSetting() const;
 };
 
 #endif // BITCOIN_QML_MODELS_OPTIONS_MODEL_H