Skip to content

Commit 01a66e2

Browse files
committed
Merge bitcoin/bitcoin#26546: test: remove unused class NodePongAdd1
40bdc8a test: remove unused class `NodePongAdd1` (Sebastian Falbesoner) Pull request description: This class was introduced in commit fa33654 ("net: Use mockable time for ping/pong, add tests"), but actually never used. ACKs for top commit: stickies-v: ACK 40bdc8a Tree-SHA512: b5a6552e4f2e0b7e368a071cc53b9a8e6f5d1950565a9fda8eb1971a01d8be0541d066842723ef44174fe8189925fa36f2defb6d7bf8d104abc77de410cc4c13
2 parents 0968c51 + 40bdc8a commit 01a66e2

File tree

1 file changed

+2
-8
lines changed

1 file changed

+2
-8
lines changed

test/functional/p2p_ping.py

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -12,27 +12,21 @@
1212
from test_framework.test_framework import BitcoinTestFramework
1313
from test_framework.util import assert_equal
1414

15+
1516
PING_INTERVAL = 2 * 60
17+
TIMEOUT_INTERVAL = 20 * 60
1618

1719

1820
class msg_pong_corrupt(msg_pong):
1921
def serialize(self):
2022
return b""
2123

2224

23-
class NodePongAdd1(P2PInterface):
24-
def on_ping(self, message):
25-
self.send_message(msg_pong(message.nonce + 1))
26-
27-
2825
class NodeNoPong(P2PInterface):
2926
def on_ping(self, message):
3027
pass
3128

3229

33-
TIMEOUT_INTERVAL = 20 * 60
34-
35-
3630
class PingPongTest(BitcoinTestFramework):
3731
def set_test_params(self):
3832
self.setup_clean_chain = True

0 commit comments

Comments
 (0)