Skip to content

Commit 035f349

Browse files
committed
Merge #15164: qa: Ignore shellcheck warning SC2236
f652f85 qa: Ignore shellcheck warning SC2236 (João Barbosa) Pull request description: With shellcheck 0.6.0 the warning `SC2236 - Use -n instead of ! -z` is raised. This change adds that warning to the ignored list. Tree-SHA512: 7b0dfbce55e5da4efb927e251257993cdf67cd1c90f8490d99fa75bf6e233bbee79ea1c59d28774994c59862c5eac061313aa154833284950fc844bda60a54e9
2 parents 7633529 + f652f85 commit 035f349

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

test/lint/lint-shell.sh

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,5 +43,6 @@ fi
4343
# SC2206: Quote to prevent word splitting, or split robustly with mapfile or read -a.
4444
# SC2207: Prefer mapfile or read -a to split command output (or quote to avoid splitting).
4545
# SC2230: which is non-standard. Use builtin 'command -v' instead.
46-
shellcheck -e SC1087,SC1117,SC2001,SC2004,SC2005,SC2006,SC2016,SC2028,SC2046,SC2048,SC2066,SC2086,SC2116,SC2148,SC2162,SC2166,SC2181,SC2206,SC2207,SC2230 \
46+
# SC2236: Don't force -n instead of ! -z.
47+
shellcheck -e SC1087,SC1117,SC2001,SC2004,SC2005,SC2006,SC2016,SC2028,SC2046,SC2048,SC2066,SC2086,SC2116,SC2148,SC2162,SC2166,SC2181,SC2206,SC2207,SC2230,SC2236 \
4748
$(git ls-files -- "*.sh" | grep -vE 'src/(secp256k1|univalue)/')

0 commit comments

Comments
 (0)