Skip to content

Commit 04226f8

Browse files
author
MarcoFalke
committed
Merge #15279: wallet: Clarify rescanblockchain doc
fa5e6ef wallet: Fixup rescanblockchain result doc (MarcoFalke) Pull request description: This was probably accidentally added to the wrong line when addressing the feedback here: bitcoin/bitcoin#7061 (comment) I already added the default values in #14877, but it could be clarified more that this really has no specific block height as default value, since the tip can change during a rescan. Tree-SHA512: 48a3c5143e2b7129ee8f396d2e77550cb393fbe45f5936aeebeb7a201d61560336a3ae47b26bb757a4dbbe217e06abfd67a5a673aef266b6c4d7a80d049a2b49
2 parents a47319d + fa5e6ef commit 04226f8

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

src/wallet/rpcwallet.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3407,12 +3407,12 @@ UniValue rescanblockchain(const JSONRPCRequest& request)
34073407
"\nRescan the local blockchain for wallet related transactions.\n",
34083408
{
34093409
{"start_height", RPCArg::Type::NUM, /* opt */ true, /* default_val */ "0", "block height where the rescan should start"},
3410-
{"stop_height", RPCArg::Type::NUM, /* opt */ true, /* default_val */ "tip height", "the last block height that should be scanned"},
3410+
{"stop_height", RPCArg::Type::NUM, /* opt */ true, /* default_val */ "", "the last block height that should be scanned. If none is provided it will rescan up to the tip at return time of this call."},
34113411
},
34123412
RPCResult{
34133413
"{\n"
3414-
" \"start_height\" (numeric) The block height where the rescan has started. If omitted, rescan started from the genesis block.\n"
3415-
" \"stop_height\" (numeric) The height of the last rescanned block. If omitted, rescan stopped at the chain tip.\n"
3414+
" \"start_height\" (numeric) The block height where the rescan has started.\n"
3415+
" \"stop_height\" (numeric) The height of the last rescanned block.\n"
34163416
"}\n"
34173417
},
34183418
RPCExamples{

0 commit comments

Comments
 (0)