Skip to content

Commit 05255d5

Browse files
committed
cmake: Drop dependency on sed for translate target
1 parent d5054be commit 05255d5

File tree

2 files changed

+7
-16
lines changed

2 files changed

+7
-16
lines changed

share/qt/translate.cmake

Lines changed: 7 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ set(input_variables
88
LCONVERT_EXECUTABLE
99
LUPDATE_EXECUTABLE
1010
PYTHON_EXECUTABLE
11-
SED_EXECUTABLE
1211
XGETTEXT_EXECUTABLE
1312
)
1413

@@ -73,13 +72,11 @@ execute_process(
7372
COMMAND_ERROR_IS_FATAL ANY
7473
)
7574

76-
execute_process(
77-
COMMAND ${SED_EXECUTABLE}
78-
-i.old
79-
-e "s|source-language=\"en\" target-language=\"en\"|source-language=\"en\"|"
80-
-e "/<target xml:space=\"preserve\"><\\/target>/d"
81-
${PROJECT_SOURCE_DIR}/src/qt/locale/bitcoin_en.xlf
82-
COMMAND_ERROR_IS_FATAL ANY
75+
file(READ "${PROJECT_SOURCE_DIR}/src/qt/locale/bitcoin_en.xlf" bitcoin_en)
76+
string(REPLACE "source-language=\"en\" target-language=\"en\""
77+
"source-language=\"en\"" bitcoin_en "${bitcoin_en}"
8378
)
84-
85-
file(REMOVE "${PROJECT_SOURCE_DIR}/src/qt/locale/bitcoin_en.xlf.old")
79+
string(REGEX REPLACE " *<target xml:space=\"preserve\"></target>\n"
80+
"" bitcoin_en "${bitcoin_en}"
81+
)
82+
file(WRITE "${PROJECT_SOURCE_DIR}/src/qt/locale/bitcoin_en.xlf" "${bitcoin_en}")

src/qt/CMakeLists.txt

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -290,23 +290,17 @@ if(BUILD_GUI_TESTS)
290290
endif()
291291

292292
find_program(XGETTEXT_EXECUTABLE xgettext)
293-
find_program(SED_EXECUTABLE sed)
294293
if(NOT XGETTEXT_EXECUTABLE)
295294
add_custom_target(translate
296295
COMMAND ${CMAKE_COMMAND} -E echo "Error: GNU gettext-tools not found"
297296
)
298-
elseif(NOT SED_EXECUTABLE)
299-
add_custom_target(translate
300-
COMMAND ${CMAKE_COMMAND} -E echo "Error: GNU sed not found"
301-
)
302297
else()
303298
add_custom_target(translate COMMAND ${CMAKE_COMMAND}
304299
-D "PROJECT_SOURCE_DIR=${PROJECT_SOURCE_DIR}"
305300
-D "COPYRIGHT_HOLDERS=${COPYRIGHT_HOLDERS}"
306301
-D "LCONVERT_EXECUTABLE=$<TARGET_FILE:Qt6::lconvert>"
307302
-D "LUPDATE_EXECUTABLE=$<TARGET_FILE:Qt6::lupdate>"
308303
-D "PYTHON_EXECUTABLE=$<TARGET_FILE:Python3::Interpreter>"
309-
-D "SED_EXECUTABLE=${SED_EXECUTABLE}"
310304
-D "XGETTEXT_EXECUTABLE=${XGETTEXT_EXECUTABLE}"
311305
-P ${PROJECT_SOURCE_DIR}/share/qt/translate.cmake
312306
)

0 commit comments

Comments
 (0)