refactor, subprocess: Remove unused Popen::child_created_ data member

hebasto · hebasto · commit 05b6f8793c6d · 2024-05-10T14:47:15.000+01:00
diff --git a/src/util/subprocess.h b/src/util/subprocess.h
@@ -1027,7 +1027,6 @@ class Popen
   std::vector<std::string> vargs_;
   std::vector<char*> cargv_;
 
-  bool child_created_ = false;
   // Pid of the child process
   int child_pid_ = -1;
 
@@ -1177,8 +1176,6 @@ inline void Popen::execute_process() noexcept(false)
     throw OSError("fork failed", errno);
   }
 
-  child_created_ = true;
-
   if (child_pid_ == 0)
   {
     // Close descriptors belonging to parent

Original file line number	Diff line number	Diff line change
`@@ -1027,7 +1027,6 @@ class Popen`
`1027`	`1027`	`std::vector<std::string> vargs_;`
`1028`	`1028`	`std::vector<char*> cargv_;`
`1029`	`1029`
`1030`		`- bool child_created_ = false;`
`1031`	`1030`	`// Pid of the child process`
`1032`	`1031`	`int child_pid_ = -1;`
`1033`	`1032`
`@@ -1177,8 +1176,6 @@ inline void Popen::execute_process() noexcept(false)`
`1177`	`1176`	`throw OSError("fork failed", errno);`
`1178`	`1177`	`}`
`1179`	`1178`
`1180`		`- child_created_ = true;`
`1181`		`-`
`1182`	`1179`	`if (child_pid_ == 0)`
`1183`	`1180`	`{`
`1184`	`1181`	`// Close descriptors belonging to parent`