test, refactor: Avoid CScriptCheck::swap in transaction_tests

hebasto · hebasto · commit 06820032142a · 2023-03-21T13:03:30.000Z
diff --git a/src/test/transaction_tests.cpp b/src/test/transaction_tests.cpp
@@ -547,9 +547,7 @@ BOOST_AUTO_TEST_CASE(test_big_witness_transaction)
 
     for(uint32_t i = 0; i < mtx.vin.size(); i++) {
         std::vector<CScriptCheck> vChecks;
-        CScriptCheck check(coins[tx.vin[i].prevout.n].out, tx, i, SCRIPT_VERIFY_P2SH | SCRIPT_VERIFY_WITNESS, false, &txdata);
-        vChecks.push_back(CScriptCheck());
-        check.swap(vChecks.back());
+        vChecks.emplace_back(coins[tx.vin[i].prevout.n].out, tx, i, SCRIPT_VERIFY_P2SH | SCRIPT_VERIFY_WITNESS, false, &txdata);
         control.Add(vChecks);
     }
 

Original file line number	Diff line number	Diff line change
`@@ -547,9 +547,7 @@ BOOST_AUTO_TEST_CASE(test_big_witness_transaction)`
`547`	`547`
`548`	`548`	`for(uint32_t i = 0; i < mtx.vin.size(); i++) {`
`549`	`549`	`std::vector<CScriptCheck> vChecks;`
`550`		`- CScriptCheck check(coins[tx.vin[i].prevout.n].out, tx, i, SCRIPT_VERIFY_P2SH \| SCRIPT_VERIFY_WITNESS, false, &txdata);`
`551`		`- vChecks.push_back(CScriptCheck());`
`552`		`- check.swap(vChecks.back());`
	`550`	`+ vChecks.emplace_back(coins[tx.vin[i].prevout.n].out, tx, i, SCRIPT_VERIFY_P2SH \| SCRIPT_VERIFY_WITNESS, false, &txdata);`
`553`	`551`	`control.Add(vChecks);`
`554`	`552`	`}`
`555`	`553`