Skip to content

Commit 0749808

Browse files
committed
CheckMinimalPush comments are prescriptive
1 parent 176db61 commit 0749808

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

src/script/interpreter.cpp

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -223,22 +223,22 @@ bool static CheckMinimalPush(const valtype& data, opcodetype opcode) {
223223
// Excludes OP_1NEGATE, OP_1-16 since they are by definition minimal
224224
assert(0 <= opcode && opcode <= OP_PUSHDATA4);
225225
if (data.size() == 0) {
226-
// Could have used OP_0.
226+
// Should have used OP_0.
227227
return opcode == OP_0;
228228
} else if (data.size() == 1 && data[0] >= 1 && data[0] <= 16) {
229-
// Could have used OP_1 .. OP_16.
229+
// Should have used OP_1 .. OP_16.
230230
return false;
231231
} else if (data.size() == 1 && data[0] == 0x81) {
232-
// Could have used OP_1NEGATE.
232+
// Should have used OP_1NEGATE.
233233
return false;
234234
} else if (data.size() <= 75) {
235-
// Could have used a direct push (opcode indicating number of bytes pushed + those bytes).
235+
// Must have used a direct push (opcode indicating number of bytes pushed + those bytes).
236236
return opcode == data.size();
237237
} else if (data.size() <= 255) {
238-
// Could have used OP_PUSHDATA.
238+
// Must have used OP_PUSHDATA.
239239
return opcode == OP_PUSHDATA1;
240240
} else if (data.size() <= 65535) {
241-
// Could have used OP_PUSHDATA2.
241+
// Must have used OP_PUSHDATA2.
242242
return opcode == OP_PUSHDATA2;
243243
}
244244
return true;

0 commit comments

Comments
 (0)