Skip to content

Commit 07b9aad

Browse files
committed
gui: Expose BitcoinGUI::unsubscribeFromCoreSignals
Move only change that makes unsubscribeFromCoreSignals public. It must be called if the event loop is not running otherwise core signals handlers can deadlock.
1 parent 60e190c commit 07b9aad

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

src/qt/bitcoingui.h

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -95,6 +95,9 @@ class BitcoinGUI : public QMainWindow
9595
*/
9696
bool hasTrayIcon() const { return trayIcon; }
9797

98+
/** Disconnect core signals from GUI client */
99+
void unsubscribeFromCoreSignals();
100+
98101
protected:
99102
void changeEvent(QEvent *e);
100103
void closeEvent(QCloseEvent *event);
@@ -184,8 +187,6 @@ class BitcoinGUI : public QMainWindow
184187

185188
/** Connect core signals to GUI client */
186189
void subscribeToCoreSignals();
187-
/** Disconnect core signals from GUI client */
188-
void unsubscribeFromCoreSignals();
189190

190191
/** Update UI with latest network info from model. */
191192
void updateNetworkState();

0 commit comments

Comments
 (0)