Skip to content

Commit 09b30db

Browse files
committed
Asserts that the tx version number is a signed 32-bit integer.
1 parent 5f0c6a7 commit 09b30db

File tree

1 file changed

+19
-4
lines changed

1 file changed

+19
-4
lines changed

test/functional/rpc_rawtransaction.py

Lines changed: 19 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,13 +14,10 @@
1414

1515
from collections import OrderedDict
1616
from io import BytesIO
17+
from test_framework.messages import CTransaction, ToHex
1718
from test_framework.test_framework import BitcoinTestFramework
18-
from test_framework.messages import (
19-
CTransaction,
20-
)
2119
from test_framework.util import *
2220

23-
2421
class multidict(dict):
2522
"""Dictionary that allows duplicate keys.
2623
@@ -363,5 +360,23 @@ def run_test(self):
363360
decrawtx= self.nodes[0].decoderawtransaction(rawtx)
364361
assert_equal(decrawtx['vin'][0]['sequence'], 4294967294)
365362

363+
####################################
364+
# TRANSACTION VERSION NUMBER TESTS #
365+
####################################
366+
367+
# Test the minimum transaction version number that fits in a signed 32-bit integer.
368+
tx = CTransaction()
369+
tx.nVersion = -0x80000000
370+
rawtx = ToHex(tx)
371+
decrawtx = self.nodes[0].decoderawtransaction(rawtx)
372+
assert_equal(decrawtx['version'], -0x80000000)
373+
374+
# Test the maximum transaction version number that fits in a signed 32-bit integer.
375+
tx = CTransaction()
376+
tx.nVersion = 0x7fffffff
377+
rawtx = ToHex(tx)
378+
decrawtx = self.nodes[0].decoderawtransaction(rawtx)
379+
assert_equal(decrawtx['version'], 0x7fffffff)
380+
366381
if __name__ == '__main__':
367382
RawTransactionsTest().main()

0 commit comments

Comments
 (0)