Skip to content

Commit 113a7a3

Browse files
committed
build: remove ENABLE_HARDENING cond from check-security
This check is only used in release builds, where hardening should always be enabled. I can't think of a reason we'd want to silently skip these checks if hardening was inadvertently disabled.
1 parent 9da0820 commit 113a7a3

File tree

1 file changed

+5
-9
lines changed

1 file changed

+5
-9
lines changed

cmake/module/Maintenance.cmake

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -35,15 +35,11 @@ function(add_maintenance_targets)
3535
VERBATIM
3636
)
3737

38-
if(ENABLE_HARDENING)
39-
add_custom_target(check-security
40-
COMMAND ${CMAKE_COMMAND} -E echo "Checking binary security..."
41-
COMMAND ${PYTHON_COMMAND} ${PROJECT_SOURCE_DIR}/contrib/devtools/security-check.py ${executables}
42-
VERBATIM
43-
)
44-
else()
45-
add_custom_target(check-security)
46-
endif()
38+
add_custom_target(check-security
39+
COMMAND ${CMAKE_COMMAND} -E echo "Checking binary security..."
40+
COMMAND ${PYTHON_COMMAND} ${PROJECT_SOURCE_DIR}/contrib/devtools/security-check.py ${executables}
41+
VERBATIM
42+
)
4743
endfunction()
4844

4945
function(add_windows_deploy_target)

0 commit comments

Comments
 (0)