Commit 144f98d
committed
Merge bitcoin/bitcoin#31337: build: Fix coverage builds
01a7298 build: Avoid using the `-ffile-prefix-map` compiler option (Hennadii Stepanov)
Pull request description:
This PR follows up on bitcoin/bitcoin#30811, which inadvertently broke coverage builds:
1. For GCC. See bitcoin/bitcoin#31337 (comment).
2. For [Clang's source-based code coverage](https://clang.llvm.org/docs/SourceBasedCodeCoverage.html) in the OSS-Fuzz environment due to its use of other options and a third party script. See https://issues.oss-fuzz.com/issues/379122777.
The root cause of this regression is that the `-ffile-prefix-map` option implicitly applies:
- [`-fprofile-prefix-map`](https://gcc.gnu.org/onlinedocs/gcc/Instrumentation-Options.html#index-fprofile-prefix-map) when using GCC.
- [`-fcoverage-prefix-map`](https://clang.llvm.org/docs/ClangCommandLineReference.html#cmdoption-clang-fcoverage-prefix-map) when using Clang. ~This behaviour is not explicitly documented~ See llvm/llvm-project@994c544.
With this PR, only the `-fdebug-prefix-map` and `-fmacro-prefix-map` options are applied.
**Note for reviewers:** Please ensure that bitcoin/bitcoin#30799 is not reintroduced.
ACKs for top commit:
maflcko:
review ACK 01a7298
dergoegge:
tACK 01a7298
Tree-SHA512: 70b11d769d2653c1528ffe1d430b79f20b061037bcb1db6addb261aa2c7be20c4bc4328ccff919adb72e81aa2e65b885c970cce3837aeeb3ca0a98b32b83d2e31 file changed
+10
-2
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
438 | 438 | | |
439 | 439 | | |
440 | 440 | | |
441 | | - | |
442 | | - | |
| 441 | + | |
| 442 | + | |
| 443 | + | |
| 444 | + | |
| 445 | + | |
| 446 | + | |
| 447 | + | |
| 448 | + | |
| 449 | + | |
| 450 | + | |
443 | 451 | | |
444 | 452 | | |
445 | 453 | | |
| |||
0 commit comments