Skip to content

Commit 158e1a6

Browse files
committed
[QA] fix mininode CAddress ser/deser
1 parent fa999af commit 158e1a6

File tree

1 file changed

+11
-6
lines changed

1 file changed

+11
-6
lines changed

test/functional/test_framework/messages.py

100644100755
Lines changed: 11 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -181,19 +181,24 @@ def ToHex(obj):
181181

182182
class CAddress():
183183
def __init__(self):
184+
self.time = 0
184185
self.nServices = 1
185186
self.pchReserved = b"\x00" * 10 + b"\xff" * 2
186187
self.ip = "0.0.0.0"
187188
self.port = 0
188189

189-
def deserialize(self, f):
190+
def deserialize(self, f, with_time=True):
191+
if with_time:
192+
self.time = struct.unpack("<i", f.read(4))[0]
190193
self.nServices = struct.unpack("<Q", f.read(8))[0]
191194
self.pchReserved = f.read(12)
192195
self.ip = socket.inet_ntoa(f.read(4))
193196
self.port = struct.unpack(">H", f.read(2))[0]
194197

195-
def serialize(self):
198+
def serialize(self, with_time=True):
196199
r = b""
200+
if with_time:
201+
r += struct.pack("<i", self.time)
197202
r += struct.pack("<Q", self.nServices)
198203
r += self.pchReserved
199204
r += socket.inet_aton(self.ip)
@@ -853,11 +858,11 @@ def deserialize(self, f):
853858
self.nServices = struct.unpack("<Q", f.read(8))[0]
854859
self.nTime = struct.unpack("<q", f.read(8))[0]
855860
self.addrTo = CAddress()
856-
self.addrTo.deserialize(f)
861+
self.addrTo.deserialize(f, False)
857862

858863
if self.nVersion >= 106:
859864
self.addrFrom = CAddress()
860-
self.addrFrom.deserialize(f)
865+
self.addrFrom.deserialize(f, False)
861866
self.nNonce = struct.unpack("<Q", f.read(8))[0]
862867
self.strSubVer = deser_string(f)
863868
else:
@@ -885,8 +890,8 @@ def serialize(self):
885890
r += struct.pack("<i", self.nVersion)
886891
r += struct.pack("<Q", self.nServices)
887892
r += struct.pack("<q", self.nTime)
888-
r += self.addrTo.serialize()
889-
r += self.addrFrom.serialize()
893+
r += self.addrTo.serialize(False)
894+
r += self.addrFrom.serialize(False)
890895
r += struct.pack("<Q", self.nNonce)
891896
r += ser_string(self.strSubVer)
892897
r += struct.pack("<i", self.nStartingHeight)

0 commit comments

Comments
 (0)