rpc, wallet: setwalletflags warnings are optional

achow101 · achow101 · commit 17ab31aa46f7 · 2022-04-14T14:39:21.000-04:00
Without this, trying to disable a wallet flag results in an Internal bug
detected.
diff --git a/src/wallet/rpc/wallet.cpp b/src/wallet/rpc/wallet.cpp
@@ -257,7 +257,7 @@ static RPCHelpMan setwalletflag()
                     {
                         {RPCResult::Type::STR, "flag_name", "The name of the flag that was modified"},
                         {RPCResult::Type::BOOL, "flag_state", "The new state of the flag"},
-                        {RPCResult::Type::STR, "warnings", "Any warnings associated with the change"},
+                        {RPCResult::Type::STR, "warnings", /*optional=*/true, "Any warnings associated with the change"},
                     }
                 },
                 RPCExamples{

Original file line number	Diff line number	Diff line change
`@@ -257,7 +257,7 @@ static RPCHelpMan setwalletflag()`
`257`	`257`	`{`
`258`	`258`	`{RPCResult::Type::STR, "flag_name", "The name of the flag that was modified"},`
`259`	`259`	`{RPCResult::Type::BOOL, "flag_state", "The new state of the flag"},`
`260`		`- {RPCResult::Type::STR, "warnings", "Any warnings associated with the change"},`
	`260`	`+ {RPCResult::Type::STR, "warnings", /optional=/true, "Any warnings associated with the change"},`
`261`	`261`	`}`
`262`	`262`	`},`
`263`	`263`	`RPCExamples{`