Skip to content

Commit 1e17114

Browse files
author
MarcoFalke
committed
Merge #20238: doc: Missing comments for signet parameters
9c08f33 doc: Missing comments for signet parameters (kanon) Pull request description: We have such comment in chainparams.cpp. However in Signet the comments are missing. In example... - Mainnet https://github.com/bitcoin/bitcoin/blob/d67883d01e507dd22d1281f4a4860e79d6a46a47/src/chainparams.cpp#L83-L84 - Testnet https://github.com/bitcoin/bitcoin/blob/d67883d01e507dd22d1281f4a4860e79d6a46a47/src/chainparams.cpp#L196-L197 - Regtest https://github.com/bitcoin/bitcoin/blob/d67883d01e507dd22d1281f4a4860e79d6a46a47/src/chainparams.cpp#L392-L393 ACKs for top commit: theStack: ACK 9c08f33 Tree-SHA512: d4e488cf01e50d6320282b29d776c11e6b3d423f9268226749f738a57a51f456b6bd48334d2d5a43afa782df65ea15525a0af1688003c1be6ef915c05650e147
2 parents 37a4634 + 9c08f33 commit 1e17114

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

src/chainparams.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -322,8 +322,8 @@ class SigNetParams : public CChainParams {
322322
consensus.nPowTargetSpacing = 10 * 60;
323323
consensus.fPowAllowMinDifficultyBlocks = false;
324324
consensus.fPowNoRetargeting = false;
325-
consensus.nRuleChangeActivationThreshold = 1916;
326-
consensus.nMinerConfirmationWindow = 2016;
325+
consensus.nRuleChangeActivationThreshold = 1916; // 95% of 2016
326+
consensus.nMinerConfirmationWindow = 2016; // nPowTargetTimespan / nPowTargetSpacing
327327
consensus.MinBIP9WarningHeight = 0;
328328
consensus.powLimit = uint256S("00000377ae000000000000000000000000000000000000000000000000000000");
329329
consensus.vDeployments[Consensus::DEPLOYMENT_TESTDUMMY].bit = 28;

0 commit comments

Comments
 (0)