Skip to content

Commit 1e3ed01

Browse files
committed
Merge bitcoin/bitcoin#23416: doc: Remove fee delta TODO from txmempool.cpp
fa32cc0 doc: Remove fee delta TODO from txmempool.cpp (MarcoFalke) Pull request description: This refactor request was added in commit eb30666, though it didn't explain why the refactor is needed and what the goal is. Given that this wasn't touched for more than 5 years, it doesn't seem critical. Generally, non-trivial `TODO`s make more sense as GitHub issues, so that they can be discussed and triaged more easily. ACKs for top commit: laanwj: Code review ACK fa32cc0 Tree-SHA512: 6629fef543e815136c82c38aa8ba2c4de68a5fe94c6954f2559e468f7e59052e02dd7c221d3b159be0314eaf0dbb18f74814297c58f76e2289c47e8d4f49be4e
2 parents 6c9bc14 + fa32cc0 commit 1e3ed01

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed

src/txmempool.cpp

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -481,8 +481,6 @@ void CTxMemPool::addUnchecked(const CTxMemPoolEntry &entry, setEntries &setAnces
481481
indexed_transaction_set::iterator newit = mapTx.insert(entry).first;
482482

483483
// Update transaction for any feeDelta created by PrioritiseTransaction
484-
// TODO: refactor so that the fee delta is calculated before inserting
485-
// into mapTx.
486484
CAmount delta{0};
487485
ApplyDelta(entry.GetTx().GetHash(), delta);
488486
if (delta) {

0 commit comments

Comments
 (0)