Skip to content

Commit 2384323

Browse files
committed
Merge #13859: qa: Add emojis to test_runner path and wallet filename
5e17777 qa: Create unicode tempdir in test_runner (MarcoFalke) Pull request description: Now that wallet filenames are properly quoted when used for rpc (#13823), we can add some unicode symbols to the test_runner path. Thus, the "extern" wallet that uses a full path has a unicode symbol in its name. Should add unicode coverage to * `listwallets` * `wallet.getwalletinfo` * `(un)loadwallet` Tree-SHA512: 1633fde56f8748df0cfef9c31a878c105dfaac85d1041b292261f44c4d40e96942aacbf7d6e839e8bbf979dc131d81c24ceb521e927fc8a5a71ba093f36b891b
2 parents 2ab7208 + 5e17777 commit 2384323

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

.travis.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ env:
1717
- RUN_TESTS=false
1818
- RUN_BENCH=false # Set to true for any one job that has debug enabled, to quickly check bench is not crashing or hitting assertions
1919
- DOCKER_NAME_TAG=ubuntu:18.04
20+
- LC_ALL=C.UTF-8
2021
- BOOST_TEST_RANDOM=1$TRAVIS_BUILD_ID
2122
- CCACHE_SIZE=100M
2223
- CCACHE_TEMPDIR=/tmp/.ccache-temp
@@ -32,7 +33,7 @@ before_install:
3233
- END_FOLD () { RET=$?; echo "travis_fold:end:${CURRENT_FOLD_NAME}"; return $RET; }
3334
install:
3435
- travis_retry docker pull $DOCKER_NAME_TAG
35-
- env | grep -E '^(CCACHE_|WINEDEBUG|BOOST_TEST_RANDOM|CONFIG_SHELL)' | tee /tmp/env
36+
- env | grep -E '^(CCACHE_|WINEDEBUG|LC_ALL|BOOST_TEST_RANDOM|CONFIG_SHELL)' | tee /tmp/env
3637
- if [[ $HOST = *-mingw32 ]]; then DOCKER_ADMIN="--cap-add SYS_ADMIN"; fi
3738
- DOCKER_ID=$(docker run $DOCKER_ADMIN -idt --mount type=bind,src=$TRAVIS_BUILD_DIR,dst=$TRAVIS_BUILD_DIR --mount type=bind,src=$CCACHE_DIR,dst=$CCACHE_DIR -w $TRAVIS_BUILD_DIR --env-file /tmp/env $DOCKER_NAME_TAG)
3839
- DOCKER_EXEC () { docker exec $DOCKER_ID bash -c "cd $PWD && $*"; }

test/functional/test_runner.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -229,7 +229,7 @@ def main():
229229
logging.basicConfig(format='%(message)s', level=logging_level)
230230

231231
# Create base test directory
232-
tmpdir = "%s/bitcoin_test_runner_%s" % (args.tmpdirprefix, datetime.datetime.now().strftime("%Y%m%d_%H%M%S"))
232+
tmpdir = "%s/test_runner_₿_🏃_%s" % (args.tmpdirprefix, datetime.datetime.now().strftime("%Y%m%d_%H%M%S"))
233233
os.makedirs(tmpdir)
234234

235235
logging.debug("Temporary test directory at %s" % tmpdir)

0 commit comments

Comments
 (0)