Skip to content

Commit 23a2e33

Browse files
committed
Merge bitcoin/bitcoin#34453: ci: Always print low ccache hit rate notice
fad2876 ci: Always print low ccache hit rate notice (MarcoFalke) Pull request description: Looks like the hit rate is low, even on test changes such as https://github.com/bitcoin/bitcoin/actions/runs/21476546461/job/61867393974#step:10:3349 to make it easier to debug, unconditionally print the low hit rate notice ACKs for top commit: l0rinc: ACK fad2876 sedited: ACK fad2876 Tree-SHA512: 0cd85e3572e8465ec424766b1fdb6181d7e607cae991889b46cc66e5f08354772b6040a9f14c0864d36e1f38894628819a3a7458d3ec9ea32e063257177740a0
2 parents 5401e67 + fad2876 commit 23a2e33

File tree

1 file changed

+3
-5
lines changed

1 file changed

+3
-5
lines changed

ci/test/03_test_script.sh

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -148,11 +148,9 @@ cmake --build "${BASE_BUILD_DIR}" "$MAKEJOBS" --target $GOAL || (
148148
)
149149

150150
bash -c "${PRINT_CCACHE_STATISTICS}"
151-
if [ "$CI" = "true" ]; then
152-
hit_rate=$(ccache -s | grep "Hits:" | head -1 | sed 's/.*(\(.*\)%).*/\1/')
153-
if [ "${hit_rate%.*}" -lt 75 ]; then
154-
echo "::notice title=low ccache hitrate::Ccache hit-rate in $CONTAINER_NAME was $hit_rate%"
155-
fi
151+
hit_rate=$(ccache --show-stats | grep "Hits:" | head -1 | sed 's/.*(\(.*\)%).*/\1/')
152+
if [ "${hit_rate%.*}" -lt 75 ]; then
153+
echo "::notice title=low ccache hitrate::Ccache hit-rate in $CONTAINER_NAME was $hit_rate%"
156154
fi
157155
du -sh "${DEPENDS_DIR}"/*/
158156
du -sh "${PREVIOUS_RELEASES_DIR}"

0 commit comments

Comments
 (0)