Skip to content

Commit 23daa86

Browse files
committed
Merge bitcoin/bitcoin#25027: test: Remove boost::split from getarg_tests.cpp
fafa727 test: Remove boost::split from getarg_tests.cpp (MacroFake) Pull request description: Only single spaces are used, so no need for boost. Can be tested with: ```diff diff --git a/src/test/getarg_tests.cpp b/src/test/getarg_tests.cpp index c877105..a834830490 100644 --- a/src/test/getarg_tests.cpp +++ b/src/test/getarg_tests.cpp @@ -21,8 +21,11 @@ BOOST_FIXTURE_TEST_SUITE(getarg_tests, BasicTestingSetup) void ResetArgs(ArgsManager& local_args, const std::string& strArg) { std::vector<std::string> vecArg; - if (strArg.size()) + if (strArg.size()) { boost::split(vecArg, strArg, IsSpace, boost::token_compress_on); + auto vecArg2{SplitString(strArg, ' ')}; + assert(vecArg2 == vecArg); + } // Insert dummy executable name: vecArg.insert(vecArg.begin(), "testbitcoin"); ACKs for top commit: fanquake: utACK fafa727 - After this, the last usage of `<boost/algorithm/string.hpp>` is in `httprpc.cpp`. Tree-SHA512: 038af095cfb5240216305919cdeeb12d8e3ff0424520b99785bff5353a47dfcacdc049b927d7316b13e17a3c19b5f7549c9db7c4b5f2fa78ff1816515ca28d9d
2 parents c086eba + fafa727 commit 23daa86

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

src/test/getarg_tests.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,16 +13,16 @@
1313
#include <utility>
1414
#include <vector>
1515

16-
#include <boost/algorithm/string.hpp>
1716
#include <boost/test/unit_test.hpp>
1817

1918
BOOST_FIXTURE_TEST_SUITE(getarg_tests, BasicTestingSetup)
2019

2120
void ResetArgs(ArgsManager& local_args, const std::string& strArg)
2221
{
2322
std::vector<std::string> vecArg;
24-
if (strArg.size())
25-
boost::split(vecArg, strArg, IsSpace, boost::token_compress_on);
23+
if (strArg.size()) {
24+
vecArg = SplitString(strArg, ' ');
25+
}
2626

2727
// Insert dummy executable name:
2828
vecArg.insert(vecArg.begin(), "testbitcoin");

0 commit comments

Comments
 (0)