orphanage: avoid vtx iteration when no orphans

furszy · l0rinc · commit 249889bee6b8 · 2025-07-18T16:54:16.000-07:00
diff --git a/src/node/txorphanage.cpp b/src/node/txorphanage.cpp
@@ -567,6 +567,8 @@ bool TxOrphanageImpl::HaveTxToReconsider(NodeId peer)
 }
 void TxOrphanageImpl::EraseForBlock(const CBlock& block)
 {
+    if (m_orphans.empty()) return;
+
     std::set<Wtxid> wtxids_to_erase;
     for (const CTransactionRef& ptx : block.vtx) {
         const CTransaction& block_tx = *ptx;

Original file line number	Diff line number	Diff line change
`@@ -567,6 +567,8 @@ bool TxOrphanageImpl::HaveTxToReconsider(NodeId peer)`
`567`	`567`	`}`
`568`	`568`	`void TxOrphanageImpl::EraseForBlock(const CBlock& block)`
`569`	`569`	`{`
	`570`	`+ if (m_orphans.empty()) return;`
	`571`	`+`
`570`	`572`	`std::set<Wtxid> wtxids_to_erase;`
`571`	`573`	`for (const CTransactionRef& ptx : block.vtx) {`
`572`	`574`	`const CTransaction& block_tx = *ptx;`