Skip to content

Commit 252ae71

Browse files
committed
Merge #12424: Fix rescan test failure due to unset g_address_type, g_change_type
b7f6002 Fix rescan test failure due to unset g_address_type, g_change_type (Russell Yanofsky) Pull request description: New global variables were introduced in #11403 and not setting them causes: ``` test_bitcoin: wallet/wallet.cpp:4259: CTxDestination GetDestinationForKey(const CPubKey&, OutputType): Assertion `false' failed. unknown location(0): fatal error in "importwallet_rescan": signal: SIGABRT (application abort requested) ``` It's possible to reproduce the failure reliably by running: ``` src/test/test_bitcoin --log_level=test_suite --run_test=wallet_tests/importwallet_rescan ``` Failures happen nondeterministically because boost test framework doesn't run tests in a specified order, and tests that run previously can set the global variables and mask the bug. This is similar to bug #12150. Example travis failure is https://travis-ci.org/bitcoin/bitcoin/jobs/340642010 Tree-SHA512: ab40662b3356892b726f1f552e22d58d86b5e982538741e52b37ee447a0c97c76c24ae543687edf2e25d9dd925722909d37abfae95d93bf09e23fa245a4c3351
2 parents f4f4f51 + b7f6002 commit 252ae71

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

src/wallet/test/wallet_tests.cpp

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -451,6 +451,9 @@ BOOST_FIXTURE_TEST_CASE(rescan, TestChain100Setup)
451451
// than or equal to key birthday.
452452
BOOST_FIXTURE_TEST_CASE(importwallet_rescan, TestChain100Setup)
453453
{
454+
g_address_type = OUTPUT_TYPE_DEFAULT;
455+
g_change_type = OUTPUT_TYPE_DEFAULT;
456+
454457
// Create two blocks with same timestamp to verify that importwallet rescan
455458
// will pick up both blocks, not just the first.
456459
const int64_t BLOCK_TIME = chainActive.Tip()->GetBlockTimeMax() + 5;

0 commit comments

Comments
 (0)