Skip to content

Commit 2578da6

Browse files
committed
Merge bitcoin/bitcoin#33485: test: set par=2 in default config for functional test framework
dda5228 test: set par=2 in default config for functional test framework (Andrew Toth) Pull request description: Depending on the host machine, a default `par` value can spawn up to 15 script verification threads for each node. Running the functional test suite with default `par` can exhaust file descriptors or hit other resource limits when many threads are spawned. These threads are mostly idle and the same code paths are executed with a value of `par=2`. Limit this to 2 for functional tests that do not override the default option. ACKs for top commit: maflcko: lgtm ACK dda5228 pablomartin4btc: ACK dda5228 l0rinc: Code review ACK dda5228 theStack: ACK dda5228 Tree-SHA512: 4459972330ff50ac7391141db6382579de09d84e68959eaeb5f20972bb9daf9aac1bd68355028ded9ee65e838c12dbd53e6f3bb6cdc375d269f666c19a19eaec
2 parents 25dbe4b + dda5228 commit 2578da6

File tree

1 file changed

+1
-0
lines changed
  • test/functional/test_framework

1 file changed

+1
-0
lines changed

test/functional/test_framework/util.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -474,6 +474,7 @@ def write_config(config_path, *, n, chain, extra_config="", disable_autoconnect=
474474
# min_required_fds = MIN_CORE_FDS + MAX_ADDNODE_CONNECTIONS + nBind = 151 + 8 + 3 = 162;
475475
# nMaxConnections = available_fds - min_required_fds = 256 - 161 = 94;
476476
f.write("maxconnections=94\n")
477+
f.write("par=" + str(min(2, os.cpu_count())) + "\n")
477478
f.write(extra_config)
478479

479480

0 commit comments

Comments
 (0)