Fixed a couple of bugs in the "walletdeniabilizecoin" RPC.

Author: denavila

src/wallet/rpc/spend.cpp

@@ -1762,28 +1762,33 @@ RPCHelpMan walletdeniabilizecoin()
 
             std::optional<CTxDestination> shared_address;
             std::set<COutPoint> inputs;
-            unsigned int deniabilization_cycles = 0;
+            unsigned int deniabilization_cycles = UINT_MAX;
             for (const UniValue& input : request.params[0].get_array().getValues()) {
                 uint256 txid = ParseHashO(input, "txid");
 
                 const UniValue& vout_v = input.find_value("vout");
-                if (!vout_v.isNum())
+                if (!vout_v.isNum()) {
                     throw JSONRPCError(RPC_INVALID_PARAMETER, "Invalid parameter, missing vout key");
+                }
                 int nOutput = vout_v.getInt<int>();
-                if (nOutput < 0)
+                if (nOutput < 0) {
                     throw JSONRPCError(RPC_INVALID_PARAMETER, "Invalid parameter, vout cannot be negative");
+                }
 
                 COutPoint outpoint(txid, nOutput);
                 LOCK(pwallet->cs_wallet);
                 auto walletTx = pwallet->GetWalletTx(outpoint.hash);
                 if (!walletTx) {
-                    throw JSONRPCError(RPC_WALLET_ERROR, "Transaction not found.");
+                    throw JSONRPCError(RPC_INVALID_PARAMETER, "Invalid parameter, txid not found in wallet.");
+                }
+                if (outpoint.n >= walletTx->tx->vout.size()) {
+                    throw JSONRPCError(RPC_INVALID_PARAMETER, "Invalid parameter, vout is out of range");
                 }
                 const auto& output = walletTx->tx->vout[outpoint.n];
 
                 isminetype mine = pwallet->IsMine(output);
                 if (mine == ISMINE_NO) {
-                    throw JSONRPCError(RPC_WALLET_ERROR, "Transaction's output doesn't belong to this wallet.");
+                    throw JSONRPCError(RPC_INVALID_PARAMETER, "Invalid parameter, transaction's output doesn't belong to this wallet.");
                 }
 
                 bool spendable = (mine & ISMINE_SPENDABLE) != ISMINE_NO;
@@ -1794,17 +1799,21 @@ RPCHelpMan walletdeniabilizecoin()
                         shared_address = address;
                     }
                     else if (!(*shared_address == address)) {
-                        throw JSONRPCError(RPC_INVALID_PARAMETER, "Inputs must share the same address");
+                        throw JSONRPCError(RPC_INVALID_PARAMETER, "Invalid parameter, inputs must share the same address");
                     }
                 } else {
-                    throw JSONRPCError(RPC_INVALID_PARAMETER, "Inputs must be spendable and have a valid address");
+                    throw JSONRPCError(RPC_INVALID_PARAMETER, "Invalid parameter, inputs must be spendable and have a valid address");
                 }
 
                 inputs.emplace(outpoint);
                 auto cycles_res = CalculateDeniabilizationCycles(*pwallet, outpoint);
                 deniabilization_cycles = std::min(deniabilization_cycles, cycles_res.first);
             }
 
+            if (inputs.empty()) {
+                throw JSONRPCError(RPC_INVALID_PARAMETER, "Invalid parameter, inputs must not be empty");
+            }
+
             unsigned int confirm_target = !request.params[1].isNull() ? request.params[1].getInt<unsigned int>() : 6;
             const bool add_to_wallet = !request.params[2].isNull() ? request.params[2].get_bool() : true;