Skip to content

Commit 27ee0cc

Browse files
committed
Merge #16646: qa: Run tests with UPnP disabled
b168dd3 Bugfix: QA: Run tests with UPnP disabled (Luke Dashjr) Pull request description: This replaces #16560 by adding `upnp=0` to `bitcoin.conf` rather than passing it to nodes. > Needed for builds configured with --enable-upnp-default You can test this change using: ```bash ./configure --enable-upnp-default && make -j6 && test/functional/test_runner.py feature_config_args.py ``` on master the test will fail without this change. ACKs for top commit: practicalswift: ACK b168dd3 -- diff looks correct Tree-SHA512: e639dd480dda2cffa19a679018c4bd7e4bd4d0f5e3001d6b407b833e3c166bde98b201063e267b8e45f8a20b0d53ec8bc028bec806b2357f9a7ba314cc4e2d07
2 parents ed9a2a3 + b168dd3 commit 27ee0cc

File tree

1 file changed

+1
-0
lines changed
  • test/functional/test_framework

1 file changed

+1
-0
lines changed

test/functional/test_framework/util.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -293,6 +293,7 @@ def initialize_datadir(dirname, n, chain):
293293
f.write("discover=0\n")
294294
f.write("listenonion=0\n")
295295
f.write("printtoconsole=0\n")
296+
f.write("upnp=0\n")
296297
os.makedirs(os.path.join(datadir, 'stderr'), exist_ok=True)
297298
os.makedirs(os.path.join(datadir, 'stdout'), exist_ok=True)
298299
return datadir

0 commit comments

Comments
 (0)