fuzz: Fix DecodeHexTx fuzzing harness issue

practicalswift · practicalswift · commit 28f8cb13d4d5 · 2020-11-02T22:21:03.000Z
diff --git a/src/test/fuzz/decode_tx.cpp b/src/test/fuzz/decode_tx.cpp
@@ -24,8 +24,7 @@ void test_one_input(const std::vector<uint8_t>& buffer)
     if (result_try_witness_and_maybe_no_witness) {
         assert(result_try_no_witness || result_try_witness);
     }
-    // if (result_try_no_witness) { // Uncomment when https://github.com/bitcoin/bitcoin/pull/17775 is merged
-    if (result_try_witness) { // Remove stop-gap when https://github.com/bitcoin/bitcoin/pull/17775 is merged
+    if (result_try_no_witness) {
         assert(result_try_witness_and_maybe_no_witness);
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -24,8 +24,7 @@ void test_one_input(const std::vector<uint8_t>& buffer)`
`24`	`24`	`if (result_try_witness_and_maybe_no_witness) {`
`25`	`25`	`assert(result_try_no_witness \|\| result_try_witness);`
`26`	`26`	`}`
`27`		`- // if (result_try_no_witness) { // Uncomment when https://github.com/bitcoin/bitcoin/pull/17775 is merged`
`28`		`- if (result_try_witness) { // Remove stop-gap when https://github.com/bitcoin/bitcoin/pull/17775 is merged`
	`27`	`+ if (result_try_no_witness) {`
`29`	`28`	`assert(result_try_witness_and_maybe_no_witness);`
`30`	`29`	`}`
`31`	`30`	`}`