fuzz: finer grained ImprovesFeerateDiagram check on error result

instagibbs · instagibbs · commit 2a3ada8b2181 · 2024-03-26T08:20:30.000-04:00
diff --git a/src/test/fuzz/rbf.cpp b/src/test/fuzz/rbf.cpp
@@ -178,5 +178,5 @@ FUZZ_TARGET(package_rbf, .init = initialize_package_rbf)
 
     // If internals report error, wrapper should too
     auto err_tuple{ImprovesFeerateDiagram(pool, direct_conflicts, all_conflicts, replacement_fees, replacement_vsize)};
-    if (!calc_results.has_value()) assert(err_tuple.has_value());
+    if (!calc_results.has_value()) assert(err_tuple.value().first == DiagramCheckError::UNCALCULABLE);
 }

Original file line number	Diff line number	Diff line change
`@@ -178,5 +178,5 @@ FUZZ_TARGET(package_rbf, .init = initialize_package_rbf)`
`178`	`178`
`179`	`179`	`// If internals report error, wrapper should too`
`180`	`180`	`auto err_tuple{ImprovesFeerateDiagram(pool, direct_conflicts, all_conflicts, replacement_fees, replacement_vsize)};`
`181`		`- if (!calc_results.has_value()) assert(err_tuple.has_value());`
	`181`	`+ if (!calc_results.has_value()) assert(err_tuple.value().first == DiagramCheckError::UNCALCULABLE);`
`182`	`182`	`}`