Populate services in GetLocalAddress

morcos · morcos · commit 307013469f9a · 2017-05-18T16:57:53.000-04:00
Previously if we didn't have any local addresses, GetLocalAddress would return
0.0.0.0 and then we'd swap in a peer's notion of our address in AdvertiseLocal,
but then nServices would never get set.
diff --git a/src/net.cpp b/src/net.cpp
@@ -148,7 +148,7 @@ static std::vector<CAddress> convertSeed6(const std::vector<SeedSpec6> &vSeedsIn
 // one by discovery.
 CAddress GetLocalAddress(const CNetAddr *paddrPeer, ServiceFlags nLocalServices)
 {
-    CAddress ret(CService(CNetAddr(),GetListenPort()), NODE_NONE);
+    CAddress ret(CService(CNetAddr(),GetListenPort()), nLocalServices);
     CService addr;
     if (GetLocal(addr, paddrPeer))
     {

Original file line number	Diff line number	Diff line change
`@@ -148,7 +148,7 @@ static std::vector<CAddress> convertSeed6(const std::vector<SeedSpec6> &vSeedsIn`
`148`	`148`	`// one by discovery.`
`149`	`149`	`CAddress GetLocalAddress(const CNetAddr *paddrPeer, ServiceFlags nLocalServices)`
`150`	`150`	`{`
`151`		`- CAddress ret(CService(CNetAddr(),GetListenPort()), NODE_NONE);`
	`151`	`+ CAddress ret(CService(CNetAddr(),GetListenPort()), nLocalServices);`
`152`	`152`	`CService addr;`
`153`	`153`	`if (GetLocal(addr, paddrPeer))`
`154`	`154`	`{`