refactor: Avoid locking cs_main in ProcessNewBlockHeaders

promag · promag · commit 3109a1f948f3 · 2019-09-06T00:38:53.000+01:00
diff --git a/src/validation.cpp b/src/validation.cpp
@@ -3402,7 +3402,6 @@ bool ProcessNewBlockHeaders(const std::vector<CBlockHeader>& headers, CValidatio
         }
     }
     if (NotifyHeaderTip()) {
-        LOCK(cs_main);
         if (::ChainstateActive().IsInitialBlockDownload() && ppindex && *ppindex) {
             LogPrintf("Synchronizing blockheaders, height: %d (~%.2f%%)\n", (*ppindex)->nHeight, 100.0/((*ppindex)->nHeight+(GetAdjustedTime() - (*ppindex)->GetBlockTime()) / Params().GetConsensus().nPowTargetSpacing) * (*ppindex)->nHeight);
         }

Original file line number	Diff line number	Diff line change
`@@ -3402,7 +3402,6 @@ bool ProcessNewBlockHeaders(const std::vector<CBlockHeader>& headers, CValidatio`
`3402`	`3402`	`}`
`3403`	`3403`	`}`
`3404`	`3404`	`if (NotifyHeaderTip()) {`
`3405`		`- LOCK(cs_main);`
`3406`	`3405`	`if (::ChainstateActive().IsInitialBlockDownload() && ppindex && *ppindex) {`
`3407`	`3406`	`LogPrintf("Synchronizing blockheaders, height: %d (~%.2f%%)\n", (ppindex)->nHeight, 100.0/((ppindex)->nHeight+(GetAdjustedTime() - (ppindex)->GetBlockTime()) / Params().GetConsensus().nPowTargetSpacing) (*ppindex)->nHeight);`
`3408`	`3407`	`}`