Merge pull request #3712

laanwj · laanwj · commit 319860429311 · 2014-02-25T16:24:03.000+01:00
a3138ed add test of DecodeBase58 skipping whitespace (Christian von Roques)
diff --git a/src/test/base58_tests.cpp b/src/test/base58_tests.cpp
@@ -63,6 +63,12 @@ BOOST_AUTO_TEST_CASE(base58_DecodeBase58)
     }
 
     BOOST_CHECK(!DecodeBase58("invalid", result));
+
+    // check that DecodeBase58 skips whitespace, but still fails with unexpected non-whitespace at the end.
+    BOOST_CHECK(!DecodeBase58(" \t\n\v\f\r skip \r\f\v\n\t a", result));
+    BOOST_CHECK( DecodeBase58(" \t\n\v\f\r skip \r\f\v\n\t ", result));
+    std::vector<unsigned char> expected = ParseHex("971a55");
+    BOOST_CHECK_EQUAL_COLLECTIONS(result.begin(), result.end(), expected.begin(), expected.end());
 }
 
 // Visitor to check address type

Original file line number	Diff line number	Diff line change
`@@ -63,6 +63,12 @@ BOOST_AUTO_TEST_CASE(base58_DecodeBase58)`
`63`	`63`	`}`
`64`	`64`
`65`	`65`	`BOOST_CHECK(!DecodeBase58("invalid", result));`
	`66`	`+`
	`67`	`+ // check that DecodeBase58 skips whitespace, but still fails with unexpected non-whitespace at the end.`
	`68`	`+ BOOST_CHECK(!DecodeBase58(" \t\n\v\f\r skip \r\f\v\n\t a", result));`
	`69`	`+ BOOST_CHECK( DecodeBase58(" \t\n\v\f\r skip \r\f\v\n\t ", result));`
	`70`	`+ std::vector<unsigned char> expected = ParseHex("971a55");`
	`71`	`+ BOOST_CHECK_EQUAL_COLLECTIONS(result.begin(), result.end(), expected.begin(), expected.end());`
`66`	`72`	`}`
`67`	`73`
`68`	`74`	`// Visitor to check address type`