Skip to content

Commit 32ee767

Browse files
committed
Merge bitcoin/bitcoin#24111: build: force CRCCheck in Windows installer
b3ccf26 build: force CRCCheck in Windows installer (fanquake) Pull request description: Otherwise a user can pass `/NCRC` on the command line and bypass the CRC check, meaning they could use a corrupted installer. I can't think of a reason why we'd want to allow the use of corrupted installers. [NSIS docs](https://nsis.sourceforge.io/Docs/Chapter4.html#acrccheck): > Specifies whether or not the installer will perform a CRC on itself before allowing an install. Note that if the user uses /NCRC on the command line when executing the installer, and you didn't specify 'force', the CRC will not occur, and the user will be allowed to install a (potentially) corrupted installer. ACKs for top commit: hebasto: ACK b3ccf26, I have reviewed the code and it looks OK, I agree it can be merged. prusnak: utACK b3ccf26 Tree-SHA512: 6b3c151bfd896dbf1a4af26114aec1721e4d4e6dad89eef796cd754c988b1bb03fd9a3f9889be3c754ff5b1cd7bf5bbfc126876c76038205c17807daff029319
2 parents 5b4b8f7 + b3ccf26 commit 32ee767

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

share/setup.nsi.in

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ Var StartMenuGroup
5353

5454
# Installer attributes
5555
InstallDir $PROGRAMFILES64\Bitcoin
56-
CRCCheck on
56+
CRCCheck force
5757
XPStyle on
5858
BrandingText " "
5959
ShowInstDetails show

0 commit comments

Comments
 (0)