Skip to content

Commit 398c6f0

Browse files
committed
Update walletdb comment after renaming.
Text from bitcoin/bitcoin#11851 (comment) by John Newbery <[email protected]>.
1 parent ea23945 commit 398c6f0

File tree

1 file changed

+7
-10
lines changed

1 file changed

+7
-10
lines changed

src/wallet/walletdb.h

Lines changed: 7 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -20,16 +20,13 @@
2020
/**
2121
* Overview of wallet database classes:
2222
*
23-
* - BerkeleyEnvironment is an environment in which the database exists (has no analog in dbwrapper.h)
24-
* - WalletDatabase represents a wallet database (similar to CDBWrapper in dbwrapper.h)
25-
* - BerkeleyBatch is a low-level database transaction (similar to CDBBatch in dbwrapper.h)
26-
* - WalletBatch is a modifier object for the wallet, and encapsulates a database
27-
* transaction as well as methods to act on the database (no analog in
28-
* dbwrapper.h)
23+
* - WalletBatch is an abstract modifier object for the wallet database, and encapsulates a database
24+
* batch update as well as methods to act on the database. It should be agnostic to the database implementation.
2925
*
30-
* The latter two are named confusingly, in contrast to what the names BerkeleyBatch
31-
* and WalletBatch suggest they are transient transaction objects and don't
32-
* represent the database itself.
26+
* The following classes are implementation specific:
27+
* - BerkeleyEnvironment is an environment in which the database exists.
28+
* - BerkeleyDatabase represents a wallet database.
29+
* - BerkeleyBatch is a low-level database batch update.
3330
*/
3431

3532
static const bool DEFAULT_FLUSHWALLET = true;
@@ -137,7 +134,7 @@ class CKeyMetadata
137134
};
138135

139136
/** Access to the wallet database.
140-
* This should really be named CWalletDBBatch, as it represents a single transaction at the
137+
* This represents a single transaction at the
141138
* database. It will be committed when the object goes out of scope.
142139
* Optionally (on by default) it will flush to disk as well.
143140
*/

0 commit comments

Comments
 (0)