qt: prevent recall of send commands from history

Author: waketraindev

src/qt/rpcconsole.cpp

@@ -83,6 +83,14 @@ const QStringList historyFilter = QStringList()
 
 }
 
+// List of commands that may cause unintended effects if accidentally re-executed from history
+const QStringList sensitiveFilter = QStringList()
+    << "send"
+    << "sendall"
+    << "sendmany"
+    << "sendtoaddress"
+;
+
 /* Object for executing console RPC commands in a separate thread.
 */
 class RPCExecutor : public QObject
@@ -364,6 +372,16 @@ bool RPCConsole::RPCParseCommandLine(interfaces::Node* node, std::string &strRes
 
         bool is_sensitive = !filter_ranges.empty();
 
+        if (!is_sensitive) {
+            const QString strcmd = QString::fromStdString(*pstrFilteredOut);
+            for (const QString& val : sensitiveFilter) {
+                if (strcmd.contains(val, Qt::CaseInsensitive)) {
+                    is_sensitive = true;
+                    break;
+                }
+            }
+        }
+
         // Prefix "!" to mark sensitive commands as non-executable when recalled from history
         if (is_sensitive) {
             pstrFilteredOut->insert(0, 1, '!');