Skip to content

Commit 430acb7

Browse files
committed
Merge bitcoin/bitcoin#24506: build, mac: Include arch in codesignature tarball
0189df1 build, mac: Include arch in codesignature tarball (Andrew Chow) 6e9308c guix: use latest signapple (Andrew Chow) Pull request description: Since we have two architectures for Mac binaries, having the architecture in the code signature tarball generated by `detached-sig-create.sh` allows us to avoid accidentally overwriting an existing code signature tarball during the code signing process. ACKs for top commit: fanquake: ACK 0189df1 Tree-SHA512: 7e0d282e4ced1094f36f1d26ff6e18d53449561ab3a1a95ac69eb5ff3d7b33ee4bd8fad004884806064a29541c47f9e5879c2a1fd0f54453413245bdcf53c4c7
2 parents 47bbd3f + 0189df1 commit 430acb7

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

contrib/guix/manifest.scm

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -485,7 +485,7 @@ and endian independent.")
485485
(license license:expat)))
486486

487487
(define-public python-signapple
488-
(let ((commit "9f42f3c8295d4107ee7a22e523ec17449a936f43"))
488+
(let ((commit "0777ce58e61b0e6be753a5f524149d6d47905186"))
489489
(package
490490
(name "python-signapple")
491491
(version (git-version "0.1" "1" commit))
@@ -498,7 +498,7 @@ and endian independent.")
498498
(file-name (git-file-name name commit))
499499
(sha256
500500
(base32
501-
"0j1sqi0g8k2z5y56iayh5pw9yyq1r6ry3q5zy0cdy2sispiwvdnp"))))
501+
"19axspyyfqbrfw2r53c17mi9bvm8zsb39mz8v9h7c173qkm3x5ym"))))
502502
(build-system python-build-system)
503503
(propagated-inputs
504504
`(("python-asn1crypto" ,python-asn1crypto)

contrib/macdeploy/detached-sig-create.sh

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,11 @@ set -e
88

99
ROOTDIR=dist
1010
BUNDLE="${ROOTDIR}/Bitcoin-Qt.app"
11+
BINARY="${BUNDLE}/Contents/MacOS/Bitcoin-Qt"
1112
SIGNAPPLE=signapple
1213
TEMPDIR=sign.temp
13-
OUT=signature-osx.tar.gz
14+
ARCH=$(${SIGNAPPLE} info ${BINARY} | head -n 1 | cut -d " " -f 1)
15+
OUT="signature-osx-${ARCH}.tar.gz"
1416
OUTROOT=osx/dist
1517

1618
if [ -z "$1" ]; then

0 commit comments

Comments
 (0)