wallet: bdb: drop default parameter

theuni · theuni · commit 43369f37060a · 2023-07-06T20:16:53.000Z
diff --git a/src/wallet/bdb.cpp b/src/wallet/bdb.cpp
@@ -742,7 +742,7 @@ bool BerkeleyBatch::TxnBegin()
 {
     if (!pdb || activeTxn)
         return false;
-    DbTxn* ptxn = env->TxnBegin();
+    DbTxn* ptxn = env->TxnBegin(DB_TXN_WRITE_NOSYNC);
     if (!ptxn)
         return false;
     activeTxn = ptxn;
diff --git a/src/wallet/bdb.h b/src/wallet/bdb.h
@@ -67,7 +67,7 @@ class BerkeleyEnvironment
     void CloseDb(const fs::path& filename);
     void ReloadDbEnv();
 
-    DbTxn* TxnBegin(int flags = DB_TXN_WRITE_NOSYNC)
+    DbTxn* TxnBegin(int flags)
     {
         DbTxn* ptxn = nullptr;
         int ret = dbenv->txn_begin(nullptr, &ptxn, flags);
diff --git a/src/wallet/salvage.cpp b/src/wallet/salvage.cpp
@@ -175,7 +175,7 @@ bool RecoverDatabaseFile(const ArgsManager& args, const fs::path& file_path, bil
         return false;
     }
 
-    DbTxn* ptxn = env->TxnBegin();
+    DbTxn* ptxn = env->TxnBegin(DB_TXN_WRITE_NOSYNC);
     CWallet dummyWallet(nullptr, "", std::make_unique<DummyDatabase>());
     for (KeyValPair& row : salvagedData)
     {

Original file line number	Diff line number	Diff line change
`@@ -742,7 +742,7 @@ bool BerkeleyBatch::TxnBegin()`
`742`	`742`	`{`
`743`	`743`	`if (!pdb \|\| activeTxn)`
`744`	`744`	`return false;`
`745`		`- DbTxn* ptxn = env->TxnBegin();`
	`745`	`+ DbTxn* ptxn = env->TxnBegin(DB_TXN_WRITE_NOSYNC);`
`746`	`746`	`if (!ptxn)`
`747`	`747`	`return false;`
`748`	`748`	`activeTxn = ptxn;`
Original file line number	Diff line number	Diff line change
`@@ -67,7 +67,7 @@ class BerkeleyEnvironment`
`67`	`67`	`void CloseDb(const fs::path& filename);`
`68`	`68`	`void ReloadDbEnv();`
`69`	`69`
`70`		`- DbTxn* TxnBegin(int flags = DB_TXN_WRITE_NOSYNC)`
	`70`	`+ DbTxn* TxnBegin(int flags)`
`71`	`71`	`{`
`72`	`72`	`DbTxn* ptxn = nullptr;`
`73`	`73`	`int ret = dbenv->txn_begin(nullptr, &ptxn, flags);`
Original file line number	Diff line number	Diff line change
`@@ -175,7 +175,7 @@ bool RecoverDatabaseFile(const ArgsManager& args, const fs::path& file_path, bil`
`175`	`175`	`return false;`
`176`	`176`	`}`
`177`	`177`
`178`		`- DbTxn* ptxn = env->TxnBegin();`
	`178`	`+ DbTxn* ptxn = env->TxnBegin(DB_TXN_WRITE_NOSYNC);`
`179`	`179`	`CWallet dummyWallet(nullptr, "", std::make_unique<DummyDatabase>());`
`180`	`180`	`for (KeyValPair& row : salvagedData)`
`181`	`181`	`{`