Skip to content

Commit 4381681

Browse files
author
MacroFake
committed
Merge bitcoin/bitcoin#25011: tests: Do not always create a descriptor wallet in wallet_createwallet
786b3a7 tests: Do not always create a descriptor wallet in wallet_createwallet (Andrew Chow) Pull request description: The createwallet test for some invalid parameters incorrectly always creates a descriptor wallet. This is unnecessary and also breaks the test when bdb is not compiled in. Fixes #25007 ACKs for top commit: jacobpfickes: ACK 786b3a7 Tree-SHA512: 97b0953a08adf83d5ea84cac2651253d790b43d606a2f746dd45d3ccd1fb576bab63e3835e3de592715ef8a5cb133e6f19a3ab810fedf4684072143c3cb578d4
2 parents f0a834e + 786b3a7 commit 4381681

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

test/functional/wallet_createwallet.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ def run_test(self):
2929
self.log.info("Run createwallet with invalid parameters.")
3030
# Run createwallet with invalid parameters. This must not prevent a new wallet with the same name from being created with the correct parameters.
3131
assert_raises_rpc_error(-4, "Passphrase provided but private keys are disabled. A passphrase is only used to encrypt private keys, so cannot be used for wallets with private keys disabled.",
32-
self.nodes[0].createwallet, wallet_name='w0', descriptors=True, disable_private_keys=True, passphrase="passphrase")
32+
self.nodes[0].createwallet, wallet_name='w0', disable_private_keys=True, passphrase="passphrase")
3333

3434
self.nodes[0].createwallet(wallet_name='w0')
3535
w0 = node.get_wallet_rpc('w0')

0 commit comments

Comments
 (0)