Skip to content

Commit 444dcb2

Browse files
committed
fuzz: txgraph: fix real_is_optimal flag propagation in CommitStaging
In the `txgraph` fuzz test, the `CommitStaging` step updates the `SimTxGraph` levels simply by erasing the front (=main) one in the `sims` vector, i.e. the staging level instance takes the place of the main level instance. This also includes the `real_is_optimal` flag (reflecting whether the corresponding real graph is known to be optimally linearized), without taking into account that this flag should only be set if _both_ levels before the commiting are optimal. E.g. in case of #33097, the main level is not optimally linearized, while the staging level is, and due to the incorrect propagation of the latter to the simulation incorrectly assumes that the main level is optimal, leading to the assertion fail. Fix this by setting the flag in the resulting main level explicitly. Resolves the fuzzing assertion fail in issue #33097.
1 parent 83a2216 commit 444dcb2

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

src/test/fuzz/txgraph.cpp

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -668,7 +668,10 @@ FUZZ_TARGET(txgraph)
668668
} else if (block_builders.empty() && sims.size() > 1 && command-- == 0) {
669669
// CommitStaging.
670670
real->CommitStaging();
671+
// Resulting main level is only guaranteed to be optimal if all levels are
672+
const bool main_optimal = std::all_of(sims.cbegin(), sims.cend(), [](const auto &sim) { return sim.real_is_optimal; });
671673
sims.erase(sims.begin());
674+
sims.front().real_is_optimal = main_optimal;
672675
break;
673676
} else if (sims.size() > 1 && command-- == 0) {
674677
// AbortStaging.

0 commit comments

Comments
 (0)