random: simplify FastRandomContext::randbytes using fillrand

sipa · sipa · commit 44c11769a83b · 2023-08-17T15:26:38.000-04:00
diff --git a/src/random.cpp b/src/random.cpp
@@ -593,11 +593,8 @@ uint256 FastRandomContext::rand256() noexcept
 template <typename B>
 std::vector<B> FastRandomContext::randbytes(size_t len)
 {
-    if (requires_seed) RandomSeed();
     std::vector<B> ret(len);
-    if (len > 0) {
-        rng.Keystream(MakeWritableByteSpan(ret));
-    }
+    fillrand(MakeWritableByteSpan(ret));
     return ret;
 }
 template std::vector<unsigned char> FastRandomContext::randbytes(size_t);

Original file line number	Diff line number	Diff line change
`@@ -593,11 +593,8 @@ uint256 FastRandomContext::rand256() noexcept`
`593`	`593`	`template <typename B>`
`594`	`594`	`std::vector<B> FastRandomContext::randbytes(size_t len)`
`595`	`595`	`{`
`596`		`- if (requires_seed) RandomSeed();`
`597`	`596`	`std::vector<B> ret(len);`
`598`		`- if (len > 0) {`
`599`		`- rng.Keystream(MakeWritableByteSpan(ret));`
`600`		`- }`
	`597`	`+ fillrand(MakeWritableByteSpan(ret));`
`601`	`598`	`return ret;`
`602`	`599`	`}`
`603`	`600`	`template std::vector<unsigned char> FastRandomContext::randbytes(size_t);`